Skip to content

fix(locator-generator): keep regexes with u, s, y, d and v flags #42819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yury Semikhatsky (yury-s) merged 1 commit into from
Sep 22, 2026
+10 −1
Merged

fix(locator-generator): keep regexes with u, s, y, d and v flags #42819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/isomorphic/locatorGenerators.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ function combineTokens(factory: LocatorFactory, tokens: string[][], maxOutputSiz

function detectExact(text: string): { exact?: boolean, text: string | RegExp } {
let exact = false;
const match = text.match(/^\/(.*)\/([igm]*)$/);
const match = text.match(/^\/(.*)\/([dgimsuvy]*)$/);
if (match)
return { text: new RegExp(match[1], match[2]) };
if (text.endsWith('"')) {
Expand Down
9 changes: 9 additions & 0 deletions tests/library/locator-generator.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,15 @@ it('reverse engineer locators', async ({ page }) => {
javascript: 'getByLabel(/Last\\s+name/i)',
python: 'get_by_label(re.compile(r"Last\\s+name", re.IGNORECASE))',
});
// Only JavaScript can express these flags, other languages drop them.
for (const flags of ['u', 's', 'y', 'd', 'v', 'gm']) {
for (const [engine, method] of [['text', 'getByText'], ['label', 'getByLabel']]) {
const selector = `internal:${engine}=/Hello/${flags}`;
const locatorString = asLocator('javascript', selector);
expect.soft(locatorString, selector).toBe(`${method}(/Hello/${flags})`);
expect.soft(parseLocator('javascript', locatorString, 'data-testid'), selector).toBe(selector);
}
}

expect.soft(generate(page.getByPlaceholder('hello'))).toEqual({
csharp: 'GetByPlaceholder("hello")',
Expand Down
Loading