fix(selectors): reset regex state before matching each element - #42818
Open
Abnoz.v2 (Abnoz01) wants to merge 1 commit into
Open
Abnoz.v2 (Abnoz01) wants to merge 1 commit into
Abnoz.v2 (Abnoz01) wants to merge 1 commit into
Conversation
Text and label matchers reuse one RegExp across elements. With the g or y flag, RegExp.prototype.test keeps lastIndex between calls, so every other matching element was skipped. Fixes microsoft#42813
|
Abnoz.v2 (@Abnoz01) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getByText,getByLabeland thetext-matchesengine reuse a singleRegExpacross elements. With thegoryflag,RegExp.prototype.testcarrieslastIndexbetween calls, so every other match was skipped (getByText(/foo/g)found 4 of 6 elements).lastIndexbefore each test, also in the expect text matcher, and add a test.Fixes #42813