fix(test-runner): make test.slow() extend the test timeout from any time slot - #42812
Closed
AbNoZ&v02 (Abnoz01) wants to merge 1 commit into
Closed
AbNoZ&v02 (Abnoz01) wants to merge 1 commit into
AbNoZ&v02 (Abnoz01) wants to merge 1 commit into
Conversation
…ime slot test.slow() tripled whichever time slot was currently running. A modifier callback that only depends on worker fixtures runs as a beforeAll hook in its own slot, and a fixture with its own timeout runs in its slot too, so the test itself never got the extended timeout. Always extend the test's default slot instead. Fixes microsoft#42808
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
Test results for "MCP"1 failed 8691 passed, 1474 skipped Merge workflow run. |
Contributor
Test results for "tests 1"9 flaky52028 passed, 1250 skipped Merge workflow run. |
Collaborator
|
I don't think we want to make this breaking change, unless the issue becomes very popular. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test.slow()tripled the currently running time slot. Atest.slow(callback)whose callback only uses worker fixtures runs as abeforeAll-style modifier in its own slot, so the test it ran for never got the extended timeout; the same happened fortest.slow()inside a fixture with its owntimeout.Fixes #42808