fix(aria-snapshot): quote names that only look like regexes - #42811
Merged
Merged
Conversation
The renderer left any name that starts and ends with "/" unquoted, assuming it was a generated regex. That also applied when regex conversion was off, so a literal name such as "/" produced a snapshot the parser rejects with "Unterminated regex". Fixes microsoft#42807
Yury Semikhatsky (yury-s)
approved these changes
Sep 22, 2026
| if (name) { | ||
| const stringifiedName = name.startsWith('/') && name.endsWith('/') ? name : JSON.stringify(name); | ||
| key += ' ' + stringifiedName; | ||
| // Only a name that was actually converted to a regex may be left unquoted. |
There was a problem hiding this comment.
drop the comment
Contributor
Test results for "MCP"8692 passed, 1474 skipped Merge workflow run. |
Contributor
Test results for "tests 1"4 flaky52029 passed, 1250 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderAriaSnapshotAsYamlleft any name starting and ending with/unquoted, even whenconvertStringsToRegexwas off, so<a href="/">/</a>rendered as- link /:and the parser failed withUnterminated regexon the next run.Fixes #42807