fix(client-certificates): honor browser-level proxy and proxy.bypass - #42810
Closed
AbNoZ&v02 (Abnoz01) wants to merge 1 commit into
Closed
AbNoZ&v02 (Abnoz01) wants to merge 1 commit into
AbNoZ&v02 (Abnoz01) wants to merge 1 commit into
Conversation
The client certificates interceptor replaces the browser proxy with a local SOCKS proxy, so it has to apply the user's proxy settings itself. It only received the context-level proxy and never evaluated bypass. Fixes microsoft#42806
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clientCertificates, all traffic goes through the local SOCKS interceptor, which must apply proxy settings itself. It only saw the context-levelproxy, so a browser-level proxy was dropped and requests went direct.createProxyAgentwas called without a URL, soproxy.bypasswas never evaluated and bypassed hosts were tunneled through the proxy.Fixes #42806