fix: add screen option to test runner fixtures - #42802
Closed
KARTIK SAHU (yash2277-ctrl) wants to merge 1 commit into
Closed
KARTIK SAHU (yash2277-ctrl) wants to merge 1 commit into
KARTIK SAHU (yash2277-ctrl) wants to merge 1 commit into
Conversation
Fixes microsoft#42679 The test runner was silently dropping the 'screen' key when using device descriptors (e.g., devices['iPhone 13']) via test.use(). This caused window.screen dimensions to collapse to viewport size, breaking device emulation. Changes: - Added 'screen' fixture to TestOptions in index.ts - Added 'screen' to _combinedContextOptions destructure and if-chain - Updated PlaywrightTestOptions interface to include screen property - Added regression tests for device descriptor and explicit screen usage The fix ensures screen emulation works consistently in both library mode (browser.newContext) and test runner mode (test.use).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #42679
The test runner was silently dropping the screen key when using device descriptors (e.g., devices['iPhone 13']) via est.use(). This caused window.screen dimensions to collapse to viewport size, breaking device emulation for screen readers and media queries.
Changes
Testing
Added two new test cases in playwright.config.spec.ts:
Impact
This fix ensures screen emulation works consistently in both:
Related
This contribution was developed with AI assistance (Kiro).