Skip to content

fix(network): resolve response.finished() when the request fails after the response #42787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dashgin Khudiyev (dashgin) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(network): resolve response.finished() when the request fails after the response #42787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/playwright-core/src/client/browserContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ export class BrowserContext extends ChannelOwner<channels.BrowserContextChannel>
private _onRequestFailed(request: network.Request, responseEndTiming: number, failureText: string | undefined, page: Page | null) {
request._failureText = failureText || null;
request._setResponseEndTiming(responseEndTiming);
request._response?._finishedPromise.resolve(null);
this.emit(Events.BrowserContext.RequestFailed, request);
if (page)
page.emit(Events.Page.RequestFailed, request);
Expand Down
14 changes: 14 additions & 0 deletions tests/page/page-event-network.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,20 @@ it('should fire events in proper order', async ({ page, server }) => {
expect(events).toEqual(['request', 'response', 'requestfinished']);
});

it('should resolve finished() for a 204 response', async ({ page, server }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/42786' });
server.setRoute('/204', (req, res) => {
res.statusCode = 204;
res.end();
});
await page.goto(server.EMPTY_PAGE);
const [response] = await Promise.all([
page.waitForEvent('response', r => r.url().endsWith('/204')),
page.evaluate(() => fetch('/204')),
]);
expect(await response.finished()).toBe(null);
});

it('should support redirects', async ({ page, server }) => {
const FOO_URL = server.PREFIX + '/foo.html';
const events = {};
Expand Down