Skip to content

test: fix click tests on android #42726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dmitry Gozman (dgozman) merged 1 commit into from
Sep 15, 2026
+4 −2
Merged

test: fix click tests on android #42726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/page/page-click-scroll.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ it('should scroll instantly on retry when scroll-behavior is smooth', async ({ p
html { scroll-behavior: smooth; }
body { margin: 0; }
.spacer { height: 2000px; }
#header { position: fixed; top: 0; left: 0; right: 0; height: calc(100vh - 50px); background: rgba(0, 0, 0, 0.1); }
#header { position: fixed; top: 0; left: 0; right: 0; bottom: 50px; background: rgba(0, 0, 0, 0.1); }
button { height: 30px; }
</style>
<div id="header"></div>
Expand Down
4 changes: 3 additions & 1 deletion tests/page/page-click.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,7 +1027,9 @@ it('should click in an iframe with border 2', async ({ page }) => {
expect(await page.evaluate('window._clicked')).toBe(true);
});

it('should not retain removed iframe after clicking inside it', async ({ page }) => {
it('should not retain removed iframe after clicking inside it', async ({ page, isAndroid }) => {
it.skip(isAndroid, 'requesting gc is not enough');

await page.setContent('<iframe srcdoc="<button>Click</button>"></iframe>');
const button = page.frameLocator('iframe').getByRole('button');
await button.waitFor();
Expand Down
Loading