Skip to content

fix(webview): adjust UserAgent test to work with mobile #41415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcrousso merged 1 commit into from
Jun 22, 2026
+4 −3
Merged

fix(webview): adjust UserAgent test to work with mobile #41415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/page/page-basic.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,10 @@ it('should have sane user agent', async ({ page, browserName, isElectron, isAndr
expect(part3.startsWith('AppleWebKit/')).toBe(true);
expect(part4).toBe('KHTML, like Gecko');
// 5th part encodes real browser name and engine version.
const [engine, browser] = part5.split(' ');
expect(browser.startsWith('Safari/')).toBe(true);
const tokens = part5.split(' ');
const engine = tokens[0];
const browser = tokens.find(t => t.startsWith('Safari/'));
expect(browser?.startsWith('Safari/')).toBe(true);
if (browserName === 'chromium')
expect(engine.includes('Chrome/')).toBe(true);
else
Expand Down
1 change: 0 additions & 1 deletion tests/webview/expectations/webkit-webview-page.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,6 @@ page/page-autowaiting-basic.spec.ts › should work with waitForLoadState(load)
page/page-basic.spec.ts › async stacks should work [fail]
page/page-basic.spec.ts › has navigator.webdriver set to true [fail]
page/page-basic.spec.ts › page.url should include hashes [fail]
page/page-basic.spec.ts › should have sane user agent [fail]
page/page-click-react.spec.ts › should not retarget when element is recycled on hover [fail]
page/page-click-scroll.spec.ts › should scroll into view span element [fail]
page/page-click-timeout-2.spec.ts › should timeout waiting for display:none to be gone [fail]
Expand Down
Loading