Skip to content

Fix NuGet release SBOM generation - #1779

Merged
Branden Bonaby (bbonaby) merged 1 commit into
mainfrom
user/bbonaby/fix-nuget-release-sbom
Nov 14, 2026
Merged

Branden Bonaby (bbonaby) merged 1 commit into
mainfrom
user/bbonaby/fix-nuget-release-sbom

Conversation

@bbonaby

@bbonaby Branden Bonaby (bbonaby) commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

📖 Description

SBOM generation was blocked due to Cargo.io requests being blocked via 1ES network isolation. In the end they ended up timing out, leaving the NuGet artifact without its required _manifest folder which has the sbom files for MXC. Ultimately the NuGet release pipeline failed due to this missing sbom data.

The fix here is to reuse the existing Cargo mirror setup that we have with goes to our private or public mirror. Also we'll now fail the official packaging job on SBOM errors or timeouts so this can happen sooner.

🔗 References

  • Source build 163927897 and release 163981528.
  • Checked EngHub's ADO SBOM Generator guidance for the timeout/failure settings.
  • No design/API spec required: CI-only bug fix.

🔍 Validation

  • End-to-end pipeline validation is pending. Will need to run the official ADO pipeline to verify SBOM generation, then confirm the artifact passes NuGet release SBOM validation.

✅ Checklist

  • Signed the Contributor License Agreement
  • Linked to an issue
  • For features or changes requiring a spec: linked the issue with maintainer-applied feature-accepted
  • For implementation: linked the required approved and merged design/API spec, or explained why no spec is required
  • Feature issue remains open unless this PR completes all agreed implementation, validation, and documentation
  • Updated documentation (if applicable)
  • Updated Copilot instructions (if build, architecture, or conventions changed)
  • If this PR changes Cargo.lock, the dependency-feed-check check passes (see pull request builds)

📋 Issue Type

  • Bug fix
  • Feature
  • Task
Microsoft Reviewers: Open in CodeFlow

Configure the approved Cargo mirror before the .NET packaging job runs SBOM dependency discovery. Fail official packaging on SBOM errors and timeouts instead of uploading an artifact that public release validation rejects.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: e8d6ae37-9de9-456f-b542-60c846dd26f4
@bbonaby
Branden Bonaby (bbonaby) requested a review from a team as a code owner November 14, 2026 18:32
Copilot AI balanced review requested due to automatic review settings November 14, 2026 18:32
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Pending official ADO validation leaves external 1ES SBOM execution and publication unverified, requiring maintainer confirmation of Cargo mirror/auth discovery, error/timeout propagation, and NuGet acceptance of the generated _manifest.

No open issues 🎉

What changed in this PR

This PR addresses missing SBOM manifests in MXC’s NuGet release artifacts by configuring Cargo mirror access during .NET packaging and making official SBOM failures fail the job.

Changes:

  • Reuses authenticated Cargo feed setup for official builds and public mirror setup for unofficial builds.
  • Configures official packaging jobs to fail on SBOM errors and timeouts.
  • Documents the mirror setup and required _manifest directory in the NuGet artifact.

End-to-end validation remains pending in the official build and NuGet release pipelines.

File Description
.azure-pipelines/​templates/​DotNet.Build.Job.yml Adds Cargo mirror setup and official SBOM failure settings.
.azure-pipelines/​README.md Documents SBOM generation behavior and the release manifest requirement.

Review effort: Balanced

@bbonaby

Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@bbonaby
Branden Bonaby (bbonaby) merged commit c662018 into main Nov 14, 2026
40 of 48 checks passed
@bbonaby
Branden Bonaby (bbonaby) deleted the user/bbonaby/fix-nuget-release-sbom branch November 14, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants