Repository navigation
Fix NuGet release SBOM generation - #1779
Merged
Branden Bonaby (bbonaby) merged 1 commit intoNov 14, 2026
Merged
Conversation
Configure the approved Cargo mirror before the .NET packaging job runs SBOM dependency discovery. Fail official packaging on SBOM errors and timeouts instead of uploading an artifact that public release validation rejects. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e8d6ae37-9de9-456f-b542-60c846dd26f4
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Pending official ADO validation leaves external 1ES SBOM execution and publication unverified, requiring maintainer confirmation of Cargo mirror/auth discovery, error/timeout propagation, and NuGet acceptance of the generated _manifest.
No open issues 🎉
What changed in this PR
This PR addresses missing SBOM manifests in MXC’s NuGet release artifacts by configuring Cargo mirror access during .NET packaging and making official SBOM failures fail the job.
Changes:
- Reuses authenticated Cargo feed setup for official builds and public mirror setup for unofficial builds.
- Configures official packaging jobs to fail on SBOM errors and timeouts.
- Documents the mirror setup and required
_manifestdirectory in the NuGet artifact.
End-to-end validation remains pending in the official build and NuGet release pipelines.
| File | Description |
|---|---|
.azure-pipelines/templates/DotNet.Build.Job.yml |
Adds Cargo mirror setup and official SBOM failure settings. |
.azure-pipelines/README.md |
Documents SBOM generation behavior and the release manifest requirement. |
Review effort: Balanced
Collaborator
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Anis Mohammed Khaja Mohideen (kanismohammed)
approved these changes
Nov 14, 2026
Branden Bonaby (bbonaby)
deleted the
user/bbonaby/fix-nuget-release-sbom
branch
November 14, 2026 19:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
SBOM generation was blocked due to Cargo.io requests being blocked via 1ES network isolation. In the end they ended up timing out, leaving the NuGet artifact without its required
_manifestfolder which has the sbom files for MXC. Ultimately the NuGet release pipeline failed due to this missing sbom data.The fix here is to reuse the existing Cargo mirror setup that we have with goes to our private or public mirror. Also we'll now fail the official packaging job on SBOM errors or timeouts so this can happen sooner.
🔗 References
🔍 Validation
✅ Checklist
feature-acceptedCargo.lock, thedependency-feed-checkcheck passes (see pull request builds)📋 Issue Type
Microsoft Reviewers: Open in CodeFlow