Repository navigation
Fix macOS W365 Node TLS test - #1778
Merged
Branden Bonaby (bbonaby) merged 1 commit intoNov 14, 2026
Merged
Branden Bonaby (bbonaby) merged 1 commit into
Branden Bonaby (bbonaby) merged 1 commit into
Conversation
Use an explicit OpenSSL configuration and the native fixture's P-256 server certificate profile. Preserve certificate and hostname verification while avoiding host-specific certificate extensions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e8d6ae37-9de9-456f-b542-60c846dd26f4
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The affected ADO macOS W365 Node integration has not run, so static review cannot establish that the TLS fix works with certificate and hostname verification enabled.
No open issues 🎉
What changed in this PR
This PR updates the Node W365 integration test’s TLS fixture to avoid host OpenSSL defaults and match the native fixture’s server certificate profile, while keeping certificate and hostname verification enabled.
Changes:
- Generates an explicit OpenSSL configuration with localhost and server-authentication extensions.
- Replaces the RSA key with a P-256 elliptic-curve key.
The macOS W365 Node integration pipeline has not yet been run with this fix.
| File | Description |
|---|---|
sdk/node/tests/integration/w365-fixture.ts |
Generates the TLS certificate using an explicit configuration and P-256 key. |
Review effort: Balanced
Collaborator
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Anis Mohammed Khaja Mohideen (kanismohammed)
approved these changes
Nov 14, 2026
Branden Bonaby (bbonaby)
deleted the
user/bbonaby/fix-macos-w365-node-test-in-ADO-pipeline
branch
November 14, 2026 19:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
This PR isolates certificate generation from host OpenSSL defaults and have the test config match the test W365 servers profile. This is an attempt to fix the ADO build test failure from: 163927654.
🔗 References
🔍 Validation
✅ Checklist
feature-acceptedCargo.lock, thedependency-feed-checkcheck passes (see pull request builds)📋 Issue Type
Microsoft Reviewers: Open in CodeFlow