Skip to content

Fix macOS W365 Node TLS test - #1778

Merged
Branden Bonaby (bbonaby) merged 1 commit into
mainfrom
user/bbonaby/fix-macos-w365-node-test-in-ADO-pipeline
Nov 14, 2026
Merged

Branden Bonaby (bbonaby) merged 1 commit into
mainfrom
user/bbonaby/fix-macos-w365-node-test-in-ADO-pipeline

Conversation

@bbonaby

@bbonaby Branden Bonaby (bbonaby) commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

📖 Description

This PR isolates certificate generation from host OpenSSL defaults and have the test config match the test W365 servers profile. This is an attempt to fix the ADO build test failure from: 163927654.

🔗 References

  • ADO build 163927654.
  • No design/API spec required: test-fixture-only bug fix.

🔍 Validation

  • ADO macOS W365 Node integration has not been run with this fix. Will run /azp run to confirm this fixes ado pipeline issue.

✅ Checklist

  • Signed the Contributor License Agreement
  • Linked to an issue
  • For features or changes requiring a spec: linked the issue with maintainer-applied feature-accepted
  • For implementation: linked the required approved and merged design/API spec, or explained why no spec is required
  • Feature issue remains open unless this PR completes all agreed implementation, validation, and documentation
  • Updated documentation (if applicable)
  • Updated Copilot instructions (if build, architecture, or conventions changed)
  • If this PR changes Cargo.lock, the dependency-feed-check check passes (see pull request builds)

📋 Issue Type

  • Bug fix
  • Feature
  • Task
Microsoft Reviewers: Open in CodeFlow

Use an explicit OpenSSL configuration and the native fixture's P-256 server certificate profile. Preserve certificate and hostname verification while avoiding host-specific certificate extensions.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: e8d6ae37-9de9-456f-b542-60c846dd26f4
@bbonaby
Branden Bonaby (bbonaby) requested a review from a team as a code owner November 14, 2026 18:32
Copilot AI balanced review requested due to automatic review settings November 14, 2026 18:32
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The affected ADO macOS W365 Node integration has not run, so static review cannot establish that the TLS fix works with certificate and hostname verification enabled.

No open issues 🎉

What changed in this PR

This PR updates the Node W365 integration test’s TLS fixture to avoid host OpenSSL defaults and match the native fixture’s server certificate profile, while keeping certificate and hostname verification enabled.

Changes:

  • Generates an explicit OpenSSL configuration with localhost and server-authentication extensions.
  • Replaces the RSA key with a P-256 elliptic-curve key.

The macOS W365 Node integration pipeline has not yet been run with this fix.

File Description
sdk/​node/​tests/​integration/​w365-fixture.ts Generates the TLS certificate using an explicit configuration and P-256 key.

Review effort: Balanced

@bbonaby

Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@bbonaby Branden Bonaby (bbonaby) changed the title Fix macOS W365 Node TLS fixture Fix macOS W365 Node TLS test Nov 14, 2026
@bbonaby
Branden Bonaby (bbonaby) merged commit 1c145a4 into main Nov 14, 2026
44 of 48 checks passed
@bbonaby
Branden Bonaby (bbonaby) deleted the user/bbonaby/fix-macos-w365-node-test-in-ADO-pipeline branch November 14, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants