Repository navigation
Fix ADO npm caching and package releases - #1777
Merged
Branden Bonaby (bbonaby) merged 5 commits intoNov 14, 2026
Merged
Branden Bonaby (bbonaby) merged 5 commits into
Branden Bonaby (bbonaby) merged 5 commits into
Conversation
Remove cross-run npm caches that restore multi-gigabyte SDK tarballs and fail during the post-job archive save. Stage and validate SDK and NVX npm packages independently for release. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e8d6ae37-9de9-456f-b542-60c846dd26f4
Ship npm and NuGet release selectors with their build artifacts. Both release pipelines must consume artifact inputs because 1ES rejects repository checkout in release jobs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e8d6ae37-9de9-456f-b542-60c846dd26f4
Publish the selected NVX runtime before the SDK in npm and both NuGet release targets, so a failed runtime publication prevents SDK publication. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e8d6ae37-9de9-456f-b542-60c846dd26f4
Add brief purpose headers and readable sections without changing package validation. Cover the public and internal NuGet artifact layouts in the existing selection checks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e8d6ae37-9de9-456f-b542-60c846dd26f4
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
Author
|
/azp run |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
ADO/1ES validation is still pending for artifact-provided selector execution, release publishing order, and resolution of npm cache post-job failures, none of which local selector fixtures establish.
No open issues 🎉
What changed in this PR
Follows up on #1774 to address Azure DevOps npm cache failures and improve MXC package releases, without changing public APIs or schemas.
Changes:
- Removes shared npm caches from packaging and SDK test jobs.
- Adds independent npm SDK/NVX selection, publishes NVX first for npm and NuGet, and runs selectors from build artifacts.
- Adds npm selection regression tests and extends NuGet coverage. Azure DevOps verification remains pending.
| File | Description |
|---|---|
scripts/ci/test-nuget-release-selection.ps1 |
Tests artifact-local selection, public/internal versions, and NVX-first ordering. |
scripts/ci/test-npm-release-selection.ps1 |
Adds package selection, staging, and rejection tests. |
.github/workflows/Build.Windows.Job.yml |
Runs npm selection tests on Windows x64. |
.azure-pipelines/templates/SDK.Unit.Test.Job.yml |
Removes shared npm caching from unit tests. |
.azure-pipelines/templates/SDK.Integration.Test.Job.yml |
Removes shared npm caching from integration tests. |
.azure-pipelines/templates/Package.NpmSdk.Job.yml |
Removes shared npm caching and bundles the release selector. |
.azure-pipelines/templates/DotNet.Build.Job.yml |
Bundles the NuGet release selector. |
.azure-pipelines/scripts/select-npm-packages.ps1 |
Validates and stages selected npm packages. |
.azure-pipelines/scripts/select-dotnet-nuget-packages.ps1 |
Clarifies selection stages and simplifies error handling. |
.azure-pipelines/README.md |
Documents package selection and partial-release retries. |
.azure-pipelines/1ES.Release.Nuget.yml |
Uses the artifact-local selector and publishes NVX first. |
.azure-pipelines/1ES.Release.Npm.yml |
Adds independent package selection and NVX-first publishing. |
Review effort: Balanced
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Huzaifa Danish (huzaifa-d)
previously approved these changes
Nov 14, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e8d6ae37-9de9-456f-b542-60c846dd26f4
Huzaifa Danish (huzaifa-d)
approved these changes
Nov 14, 2026
Branden Bonaby (bbonaby)
deleted the
user/bbonaby/more-fixes-for-pipeline-and-release
branch
November 14, 2026 05:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
No API or schema changes; no design/API spec required.
🔗 References
#1774
🔍 Validation
Needs verification in the ADO build to confirm.
powershell.exe -NoProfile -File .\scripts\ci\test-npm-release-selection.ps1— passed locally.powershell.exe -NoProfile -File .\scripts\ci\test-nuget-release-selection.ps1— passed locally.✅ Checklist
feature-acceptedCargo.lock, thedependency-feed-checkcheck passes (see pull request builds)📋 Issue Type
Microsoft Reviewers: Open in CodeFlow