Skip to content

Removing reliance on TalkToSupervisor bit#653

Merged
kuqin12 merged 13 commits into
microsoft:mainfrom
kuqin12:rmv_talk_bit
May 19, 2026
Merged

Removing reliance on TalkToSupervisor bit#653
kuqin12 merged 13 commits into
microsoft:mainfrom
kuqin12:rmv_talk_bit

Conversation

@kuqin12

@kuqin12 kuqin12 commented May 15, 2026

Copy link
Copy Markdown
Contributor

Description

The added bit in the status buffer to indicate the communication target is supervisor or user. This could take a toll on the integration overhead.

This change aims at removing the override in BASECORE and uses dual status buffer to communicate to different targets.

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

This was tested on QEMU Q35 and booted to Windows desktop.

Integration Instructions

N/A

@kuqin12 kuqin12 requested review from apop5, makubacki and vineelko May 15, 2026 04:48
@codecov-commenter

codecov-commenter commented May 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 178 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.52%. Comparing base (7d35109) to head (53745bb).

Files with missing lines Patch % Lines
MmSupervisorPkg/Core/MmSupervisorCore.c 0.00% 154 Missing ⚠️
...sorPkg/Drivers/MmPeiLaunchers/Common/MmIplCommon.c 0.00% 15 Missing ⚠️
...s/MmCommunicationBuffer/MmCommunicationBufferPei.c 0.00% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #653      +/-   ##
========================================
- Coverage   0.52%   0.52%   -0.01%     
========================================
  Files        133     133              
  Lines      20103   20191      +88     
  Branches      60      60              
========================================
  Hits         106     106              
- Misses     19992   20080      +88     
  Partials       5       5              
Flag Coverage Δ
MmSupervisorPkg 0.52% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread MmSupervisorPkg/Core/MmSupervisorCore.c Outdated
Comment thread MmSupervisorPkg/Core/MmSupervisorCore.c
Comment thread MmSupervisorPkg/Core/Mem/SmmCpuMemoryManagement.c Outdated
Comment thread MmSupervisorPkg/Core/Mem/SmmCpuMemoryManagement.c Outdated
Comment thread MmSupervisorPkg/Core/Mem/SmmCpuMemoryManagement.c
Comment thread MmSupervisorPkg/Core/Mem/SmmCpuMemoryManagement.c
kuqin12 and others added 5 commits May 15, 2026 16:01
Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: kuqin12 <42554914+kuqin12@users.noreply.github.com>
Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: kuqin12 <42554914+kuqin12@users.noreply.github.com>
Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: kuqin12 <42554914+kuqin12@users.noreply.github.com>
Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: kuqin12 <42554914+kuqin12@users.noreply.github.com>
Comment thread MmSupervisorPkg/Core/Request/UpdateCommBuffer.c Outdated
Comment thread MmSupervisorPkg/Core/Request/UpdateCommBuffer.c Outdated
Comment thread MmSupervisorPkg/Drivers/MmPeiLaunchers/MmDxeSupport.c Outdated
Comment thread MmSupervisorPkg/Core/Request/UpdateCommBuffer.c Outdated
kuqin12 and others added 5 commits May 15, 2026 17:06
Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: kuqin12 <42554914+kuqin12@users.noreply.github.com>
Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: kuqin12 <42554914+kuqin12@users.noreply.github.com>
@kuqin12 kuqin12 merged commit b074347 into microsoft:main May 19, 2026
21 checks passed
@kuqin12 kuqin12 deleted the rmv_talk_bit branch May 19, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants