Removing reliance on TalkToSupervisor bit#653
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
========================================
- Coverage 0.52% 0.52% -0.01%
========================================
Files 133 133
Lines 20103 20191 +88
Branches 60 60
========================================
Hits 106 106
- Misses 19992 20080 +88
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
makubacki
reviewed
May 15, 2026
Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com> Signed-off-by: kuqin12 <42554914+kuqin12@users.noreply.github.com>
Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com> Signed-off-by: kuqin12 <42554914+kuqin12@users.noreply.github.com>
Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com> Signed-off-by: kuqin12 <42554914+kuqin12@users.noreply.github.com>
Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com> Signed-off-by: kuqin12 <42554914+kuqin12@users.noreply.github.com>
makubacki
reviewed
May 15, 2026
Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com> Signed-off-by: kuqin12 <42554914+kuqin12@users.noreply.github.com>
Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com> Signed-off-by: kuqin12 <42554914+kuqin12@users.noreply.github.com>
makubacki
approved these changes
May 19, 2026
apop5
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The added bit in the status buffer to indicate the communication target is supervisor or user. This could take a toll on the integration overhead.
This change aims at removing the override in BASECORE and uses dual status buffer to communicate to different targets.
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
This was tested on QEMU Q35 and booted to Windows desktop.
Integration Instructions
N/A