Bump MessageLength to buffer size for supervisor communications#650
Merged
Conversation
vineelko
approved these changes
May 8, 2026
makubacki
approved these changes
May 8, 2026
cfernald
approved these changes
May 8, 2026
kuqin12
enabled auto-merge (squash)
May 8, 2026 23:02
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
========================================
- Coverage 0.52% 0.52% -0.01%
========================================
Files 133 133
Lines 20101 20103 +2
Branches 60 60
========================================
Hits 106 106
- Misses 19990 19992 +2
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
apop5
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
MessageLengthhas been tied to input buffer size in the recent movement of removing core private data.This makes the caller having to change to compensate this because the buffer size was meant to indicate the total buffer size the MM core can use for the return.
Given this supervised MM environment has fixed buffer size, already pre-unblocked, it could be treated that the message length will always be covering the entire prepared buffer region.
The test is also reverted to verify the corresponding change.
How This Was Tested
This was tested on QEMU Q35 and passed the updated test app.
Integration Instructions
N/A