Skip to content

Bump MessageLength to buffer size for supervisor communications#650

Merged
kuqin12 merged 2 commits into
microsoft:mainfrom
kuqin12:patch_msg
May 8, 2026
Merged

Bump MessageLength to buffer size for supervisor communications#650
kuqin12 merged 2 commits into
microsoft:mainfrom
kuqin12:patch_msg

Conversation

@kuqin12

@kuqin12 kuqin12 commented May 8, 2026

Copy link
Copy Markdown
Contributor

Description

The MessageLength has been tied to input buffer size in the recent movement of removing core private data.

This makes the caller having to change to compensate this because the buffer size was meant to indicate the total buffer size the MM core can use for the return.

Given this supervised MM environment has fixed buffer size, already pre-unblocked, it could be treated that the message length will always be covering the entire prepared buffer region.

The test is also reverted to verify the corresponding change.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

This was tested on QEMU Q35 and passed the updated test app.

Integration Instructions

N/A

@mu-automation mu-automation Bot added the impact:security Has a security impact label May 8, 2026
@kuqin12
kuqin12 enabled auto-merge (squash) May 8, 2026 23:02
@codecov-commenter

codecov-commenter commented May 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.52%. Comparing base (cb61dae) to head (12a9ccc).

Files with missing lines Patch % Lines
...sorPkg/Drivers/MmPeiLaunchers/Common/MmIplCommon.c 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #650      +/-   ##
========================================
- Coverage   0.52%   0.52%   -0.01%     
========================================
  Files        133     133              
  Lines      20101   20103       +2     
  Branches      60      60              
========================================
  Hits         106     106              
- Misses     19990   19992       +2     
  Partials       5       5              
Flag Coverage Δ
MmSupervisorPkg 0.52% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kuqin12
kuqin12 merged commit 7d35109 into microsoft:main May 8, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:security Has a security impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants