Clean up completed communicator receives#804
Merged
Merged
Conversation
Erase completed receive bookkeeping from the communicator once the deferred receive future finishes, while preserving ordered receive chaining for repeated rank/tag operations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
/azp run mscclpp-ut |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR refactors ordered “receive” operations to centralize chaining via a helper and to clean up receive bookkeeping once the final request completes.
Changes:
- Introduces a generic
makeOrderedRecvFuturehelper to enforce ordered receive chaining per(remoteRank, tag). - Adds a
ScopeGuard-based cleanup path intended to erase completed(remoteRank, tag)entries from the “last receive” bookkeeping. - Refactors
recvMemory,connect, andbuildSemaphoreto use the new helper.
chhwang
reviewed
May 15, 2026
Contributor
Author
|
/azp run mscclpp-ut |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chhwang
approved these changes
May 15, 2026
Contributor
Author
|
/azp run mscclpp-ut |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chhwang
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary