fix(docx): properly escape special markdown characters at start of lines#2160
Open
saitejabandaru-in wants to merge 1 commit into
Open
fix(docx): properly escape special markdown characters at start of lines#2160saitejabandaru-in wants to merge 1 commit into
saitejabandaru-in wants to merge 1 commit into
Conversation
|
@saitejabandaru-in please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue where DOCX conversion with
markitdownfails to escape Markdown special characters at the beginning of a line (e.g.#,>,+), causing plain text that happens to start with these characters to be rendered as Markdown headings, blockquotes, or lists.Fixes #2157
Changes
Added escaping logic in
_markdownify.py'sprocess_textto catch line-starting Markdown block characters and escape them. Also added a pytest to verify the escaping works correctly for strings starting with#.