Skip to content

Update the workflow tigger #146

Merged
zhogu merged 5 commits into
release/1.5from
zhogu/change-trigger
Feb 6, 2026
Merged

Update the workflow tigger #146
zhogu merged 5 commits into
release/1.5from
zhogu/change-trigger

Conversation

@zhogu

@zhogu zhogu commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

This pull request updates the GitHub Actions workflow triggers and job conditions for both the build-all.yaml and build-deploy-changes.yaml workflow files. The main goal is to refine when workflows are triggered and executed, especially in relation to pull request events, and to change the default branch for workflow runs.

Workflow trigger and condition updates:

Workflow event triggers:

  • In .github/workflows/build-all.yaml, the workflow is now triggered only when a pull request targeting a release/* branch is closed, instead of on push events.
  • In .github/workflows/build-deploy-changes.yaml, the workflow is now triggered when a pull request targeting main, dev, or release/* branches is opened or closed, in addition to existing push events.

Job execution conditions:

  • Both workflow files now include a job-level condition to only run jobs if the event is not a pull request, or if the pull request has been merged. This prevents jobs from running on unmerged pull requests. [1] [2]

Default branch update:

  • The default branch for the workflow input parameter branch in build-all.yaml has been changed from main to dev.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refines GitHub Actions workflow triggers and job execution conditions to better control when builds and deployments occur. The changes ensure workflows only execute on merged pull requests or direct push events, and update the default branch for manual workflow dispatches.

Changes:

  • Modified workflow triggers to respond to specific pull request events (opened/closed) rather than all PR activities
  • Added job-level conditions to prevent execution on unmerged pull requests
  • Changed the default branch for manual workflow dispatch from 'main' to 'dev' in build-all.yaml

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/build-deploy-changes.yaml Added pull request type filters (opened, closed) and job condition to skip unmerged PRs
.github/workflows/build-all.yaml Removed push trigger, changed to pull_request with closed type only, updated default branch to 'dev', and added job condition for merged PRs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/build-deploy-changes.yaml Outdated
Comment thread .github/workflows/build-all.yaml Outdated

Copilot AI commented Feb 6, 2026

Copy link
Copy Markdown

@zhogu I've opened a new pull request, #147, to work on those changes. Once the pull request is ready, I'll request review from you.

@zhogu zhogu removed the request for review from abuccts February 6, 2026 07:00
@zhogu zhogu merged commit 9173b41 into release/1.5 Feb 6, 2026
7 checks passed
hippogr added a commit that referenced this pull request Feb 10, 2026
* Fix numa parsing in job exporter (#143)

Fix numa parsing in job exporter on GB200.

* Fix kubespray deployment on bare metal (#144)

Fix kubespray deployment on bare metal when cffi package is installed by package manager.

* fix the circular dependency (#142)

Co-authored-by: Rui Gao <ruigao@microsoft.com>

* fix more circular dependencies in rest server (#145)

Co-authored-by: Rui Gao <ruigao@microsoft.com>
Co-authored-by: zhogu <57975490+zhogu@users.noreply.github.com>

* Update the workflow tigger  (#146)

* change trigger of github workflow

* update

* update

* update

* add release note for v1.5 (#148)

Co-authored-by: Rui Gao <ruigao@microsoft.com>

---------

Co-authored-by: Yifan Xiong <yifan.xiong@microsoft.com>
Co-authored-by: Rui Gao <ruigao@microsoft.com>
Co-authored-by: zhogu <57975490+zhogu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants