Skip to content

job-exporter docker image clean#140

Merged
hippogr merged 10 commits into
devfrom
ruigao/job-exporter-clean
Mar 31, 2026
Merged

job-exporter docker image clean#140
hippogr merged 10 commits into
devfrom
ruigao/job-exporter-clean

Conversation

@hippogr

@hippogr hippogr commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

This PR is used to clean the docker build process for job-exporter to reduce the build time as well as the docker image size, as well as the tool update.

Copilot AI review requested due to automatic review settings January 20, 2026 08:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the Docker build process for the job-exporter component by introducing multi-stage builds, streamlining dependency installation, and updating tools. The changes aim to reduce both build time and final image size.

Changes:

  • Introduced multi-stage Docker build with separate builder and runtime stages to minimize final image size
  • Replaced custom-built AMD RDC and DCGM installations with pre-packaged versions from official repositories
  • Updated nerdctl from version 2.1.3 to 2.2.1

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
job-exporter.common.dockerfile Complete restructure with multi-stage build, optimized layer caching, and streamlined dependency installation
moneo-gpu-exporter_entrypoint.sh Removed DCGM update script call since DCGM 4 is now directly installed
update-dcgm.py Removed as DCGM version management is now handled during Docker build
nvidia.sh Removed as DCGM installation is now handled directly in Dockerfile
common.sh Removed as common dependencies are now installed directly in Dockerfile
amd.sh Removed as RDC installation is now handled via package manager instead of building from source

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/job-exporter/build/job-exporter.common.dockerfile Outdated
Comment thread src/job-exporter/build/job-exporter.common.dockerfile Outdated
Comment thread src/job-exporter/build/job-exporter.common.dockerfile Outdated
Comment thread src/job-exporter/build/job-exporter.common.dockerfile
Comment thread src/job-exporter/build/job-exporter.common.dockerfile Outdated
Comment thread src/job-exporter/build/job-exporter.common.dockerfile
Comment thread src/job-exporter/build/job-exporter.common.dockerfile Outdated
@hippogr
hippogr merged commit 132335c into dev Mar 31, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants