Algorithm - Add top-1 load balancing loss for MoE routing#67
Open
qghuxmu wants to merge 11 commits into
Open
Conversation
yzygitzh
reviewed
Jul 1, 2025
qghuxmu
changed the title
yzygitzh
reviewed
Jul 1, 2025
yzygitzh
reviewed
Jul 1, 2025
yzygitzh
reviewed
Jul 1, 2025
yzygitzh
reviewed
Jul 1, 2025
yzygitzh
reviewed
Jul 1, 2025
yzygitzh
reviewed
Jul 1, 2025
yzygitzh
reviewed
Jul 1, 2025
yzygitzh
reviewed
Jul 1, 2025
Contributor
|
Also please help add a test case in tests/unit_tests/transformer/moe/test_aux_loss.py @qghuxmu |
yzygitzh
previously approved these changes
Jul 1, 2025
yzygitzh
dismissed
their stale review
Please help fix UT and make all-reduce one-pass.
yzygitzh
approved these changes
Jul 2, 2025
yukirora
reviewed
Jul 2, 2025
| (see https://arxiv.org/abs/2501.11873 for details); "top1_loss" corresponds to the top-1 load balancing loss, | ||
| and "none" implies no load balancing. The default is "aux_loss".""" | ||
|
|
||
| moe_top1_loss_temperature: float = 1.0 |
Contributor
There was a problem hiding this comment.
please add the assert to filter out invalid value
yukirora
approved these changes
Jul 2, 2025
sjtu-yc
force-pushed
the
qingguo/onehot_lbl
branch
from
1c3e8c0 to
f7028c3
Compare
|
Marking as stale. No activity in 60 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new load balancing loss optimized for top-1 MoE routing. This loss mitigates the issue that even with imbalanced routing frequencies, the value of existing load balance loss could remain low.