Skip to content

[AI Generated] BugFix: Scale kdump timeouts and crashkernel size for large memory VMs #4447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gnandeep99 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[AI Generated] BugFix: Scale kdump timeouts and crashkernel size for large memory VMs #4447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions lisa/tools/kdump.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,8 +294,16 @@ def calculate_crashkernel_size(self, total_memory: str) -> str:
and float(total_memory.strip("M")) < 2048
):
crash_kernel = "256M"
elif "T" in total_memory and float(total_memory.strip("T")) > 1:
crash_kernel = "1G"
elif "T" in total_memory:
total_memory_tb = float(total_memory.strip("T"))
if total_memory_tb > 8:
crash_kernel = "4G"
elif total_memory_tb > 4:
crash_kernel = "2G"
elif total_memory_tb > 1:
crash_kernel = "1G"
Comment thread
LiliDeng marked this conversation as resolved.
else:
crash_kernel = "512M"
else:
crash_kernel = "512M"
return crash_kernel
Expand Down Expand Up @@ -854,8 +862,14 @@ def kdump_test(
# change the dump path and increase the timeout duration
kdump.config_resource_disk_dump_path(self._get_disk_dump_path())
self.timeout_of_dump_crash = 1200
if "T" in total_memory and float(total_memory.strip("T")) > 6:
self.timeout_of_dump_crash = 2000
if "T" in total_memory:
total_memory_tb = float(total_memory.strip("T"))
if total_memory_tb > 8:
self.timeout_of_dump_crash = 4800
elif total_memory_tb > 4:
self.timeout_of_dump_crash = 3600
elif total_memory_tb > 1:
self.timeout_of_dump_crash = 2400
Comment thread
LiliDeng marked this conversation as resolved.

kdump.config_crashkernel_memory(self.crash_kernel)
kdump.enable_kdump_service()
Expand All @@ -866,7 +880,15 @@ def kdump_test(
self.node.execute(f"rm -rf {kdump.dump_path}/*", shell=True, sudo=True)

# Reboot system to make kdump take effect
self.node.reboot(time_out=600)
# Large memory VMs (multi-TB) need more time for memory initialization
reboot_timeout = 600
if "T" in total_memory:
total_memory_tb = float(total_memory.strip("T"))
if total_memory_tb > 4:
reboot_timeout = 1200
elif total_memory_tb > 1:
reboot_timeout = 900
Comment thread
LiliDeng marked this conversation as resolved.
self.node.reboot(time_out=reboot_timeout)

# Confirm that the kernel dump mechanism is enabled
kdump.check_crashkernel_loaded(self.crash_kernel)
Expand Down
Loading