fix: preserve literal dollar signs in config parsing#2418
Open
Kevin-Li-2025 wants to merge 1 commit into
Open
Conversation
Author
|
Thanks for taking a look. I noticed after opening this that #2363 also addresses #2349 and keeps missing environment variable references as explicit errors while preserving literal This PR is a smaller current-base variant of the same fix with a focused regression test. I am happy to close this in favor of #2363 if maintainers prefer that existing PR; otherwise this is ready as an alternative patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$characters in config values such as regex anchors while still expanding valid environment variables$VARand${VAR}placeholders$Fixes #2349.
Root cause
string.Template.substitute()treats every$as the start of a template placeholder and raisesValueErrorfor a bare regex anchor like.*\.md$. The loader only needs strict validation for valid env-var placeholders; other$characters should remain literal config content.Tests
uv run --package graphrag-common pytest tests/unit/load_config/test_load_config.py -quv run ruff check packages/graphrag-common/graphrag_common/config/load_config.py tests/unit/load_config/test_load_config.pyuv run ruff format --check packages/graphrag-common/graphrag_common/config/load_config.py tests/unit/load_config/test_load_config.pygit diff --check