fix(config): call .strip() correctly in vector store db_uri validation#2412
Open
himanshupandeytech-ai wants to merge 1 commit into
Open
Conversation
The condition in _validate_vector_store_db_uri() compared the bound method reference store.db_uri.strip (without parentheses) to an empty string. A method reference is always truthy, so the comparison was always False — meaning a whitespace-only db_uri was never replaced with the default and was forwarded unchanged to Path.resolve(), silently producing a wrong path. Fix: add parentheses to call the method and get the stripped string. Fixes microsoft#2381 Tests added: - Parametrized regression tests for empty, whitespace-only, tab, newline, and mixed-whitespace URIs (all must fall back to the configured default). - Tests for None / omitted db_uri (existing degenerate case). - Tests for valid relative and absolute URIs (must resolve correctly).
Author
|
@microsoft-github-policy-service agree |
manjitsithuraj
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2381
The condition in
_validate_vector_store_db_uri()usedstore.db_uri.stripwithout parentheses.A bound method reference is always truthy, so the comparison
store.db_uri.strip == ""was alwaysFalse.A whitespace-only
db_uriwas never replaced with the default and was passed directly toPath.resolve().Fix
Tests
Added
tests/unit/config/test_vector_store_db_uri_validation.pycovering: