Repository navigation
Fix sparse Jacobians with empty dependencies and singleton batch axes - #48
Open
Giuseppe Carleo (gcarleo) wants to merge 1 commit into
Open
Giuseppe Carleo (gcarleo) wants to merge 1 commit into
Giuseppe Carleo (gcarleo) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sparse propagation can fail for batched attention and complex Slater wavefunctions:
find_out_idxremoves singleton position axes, butremove_zero_entriesindexes the original operands. Restore the broadcast position frame before selecting nonzero entries; a size-one batch ahead of a multi-head contraction otherwise produces out-of-bounds mask indices.-1, allowing the existing zero-Jacobian densification path instead of reducing an empty array without an identity.Regression tests compare multi-head attention values, gradients, and Laplacians against JAX autodiff for unbatched, singleton, nested-singleton, and two-item batches. The empty-mask test now also covers zero rows.
Validation with JAX 0.10.2 and two CPU devices: