Repository navigation
[Tabs] Simplify active tab ID handling - #5382
Merged
Merged
Conversation
Denis Voituron (dvoituron)
requested a review
from Vincent Baaij (vnbaaij)
as a code owner
October 1, 2026 15:16
Copilot started reviewing on behalf of
Denis Voituron (dvoituron)
October 1, 2026 15:17
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused refactor is consistent across implementation and tests with no unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Simplifies active tab ID synchronization in FluentTabs.
Changes:
- Removes redundant client-side tracking state.
- Synchronizes
activeidafter user and parameter selections. - Updates and expands tab-selection tests.
| File | Description |
|---|---|
src/Core/Components/Tabs/FluentTabs.razor.cs |
Simplifies active ID state handling. |
tests/Core/Components/Tabs/FluentTabsTests.razor |
Updates synchronization expectations and coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Denis Voituron (dvoituron)
enabled auto-merge (squash)
October 1, 2026 15:21
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.3%
Microsoft.FluentUI.AspNetCore.Components.Charts - 100%
|
Vincent Baaij (vnbaaij)
approved these changes
Oct 1, 2026
Denis Voituron (dvoituron)
deleted the
users/dvoituron/fix-tabs-activeid
branch
October 1, 2026 16:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Tabs] Simplify active tab ID handling
Refactor the handling of the active tab ID in the
FluentTabscomponent to streamline the logic and improve clarity.This change eliminates unnecessary variables and simplifies the synchronization of the active tab ID.
Example
Before
Before.mp4
After
After.mp4
Unit Tests
Added