Phase C: remove redundant npmFeed parameter#196
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
43 tasks
MicroFish91
approved these changes
Jun 5, 2026
patverb
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase C -- remove the
npmFeedparameterRemoves the now-redundant
npmFeed: ${{ variables.npmFeed }}line from theextends.parametersblock in.config/build.yml. KeepsfeedBaseUrl, which is the canonical private-feed mechanism now thatazext-pt/v1runs the fail-closed template (microsoft/vscode-azuretools#2319).This is a no-op under the live template --
npmFeedis already an ignored, no-op parameter onv1, so removing it does not change build behavior. Private-feed auth continues to be driven entirely byfeedBaseUrl.The
npmFeedvariable inazcode.variables.ymlis intentionally left in place (any repo-localadditionalSetupStepsthat reference${{ variables.npmFeed }}keep working).Part of the npm feed migration tracked in microsoft/vscode-azuretools#2320 (Phase C).