chore: drop System.Runtime.Loader package ref (in-box on net8.0)#1787
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes legacy explicit NuGet references that are now provided by the .NET 8 BCL, reducing noise and avoiding spurious vulnerability alerts in this repo’s build-time dependency scanning tooling.
Changes:
- Removed
System.Runtime.LoaderPackageReferencefromMicrosoft.ComponentDetection.Orchestrator(net8.0 via repo defaults). - Removed the centrally-managed
System.Runtime.LoaderPackageVersionentry.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.ComponentDetection.Orchestrator/Microsoft.ComponentDetection.Orchestrator.csproj | Drops the explicit System.Runtime.Loader package reference from Orchestrator. |
| Directory.Packages.props | Removes central version pin for System.Runtime.Loader after reference removal. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
JamieMagee
changed the title
System.Memory removed from net8.0-targeted projects (kept on Contracts which targets netstandard2.0). System.Runtime.Loader is in-box on net8.0 — removed from Orchestrator. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JamieMagee
force-pushed
the
cleanup/drop-transitive-packages
branch
from
b4ba819 to
90f7601
Compare
grvillic
approved these changes
Apr 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1787 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the explicit
PackageReferenceforSystem.Runtime.LoaderfromMicrosoft.ComponentDetection.Orchestratorand its centralPackageVersionentry fromDirectory.Packages.props. The type lives in the BCL on net8.0; the explicit ref is noise and occasionally triggers spurious vulnerability alerts.Why
The explicit reference dates from the netstandard / netcoreapp3.1 era when
System.Runtime.Loaderwas an out-of-band package. On net8.0 it ships with the runtime.Note
The original plan also intended to drop explicit
System.Memoryreferences from net8.0-targeted projects, but a closer look showedSystem.Memoryis only referenced byMicrosoft.ComponentDetection.Contracts.csproj, which still targetsnetstandard2.0— so it must stay. There were no net8.0System.Memoryreferences to remove. This PR therefore only coversSystem.Runtime.Loader.Verified
`dotnet build` (warnings-as-errors) succeeds with zero warnings/errors.
Part 2 of a 6-PR cleanup series removing .NET-Framework-era anachronisms.