Skip to content

chore: replace 2-string Resources.resx with constants #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamieMagee merged 1 commit into from
Apr 17, 2026
Merged

chore: replace 2-string Resources.resx with constants #1786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/Microsoft.ComponentDetection.Common/Microsoft.ComponentDetection.Common.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,4 @@
<ProjectReference Include="..\Microsoft.ComponentDetection.Contracts\Microsoft.ComponentDetection.Contracts.csproj" />
</ItemGroup>

<ItemGroup>
<Compile Update="Resources.Designer.cs">
<DependentUpon>Resources.resx</DependentUpon>
<DesignTime>True</DesignTime>
<AutoGen>True</AutoGen>
</Compile>
<EmbeddedResource Update="Resources.resx">
<LastGenOutput>Resources.Designer.cs</LastGenOutput>
<Generator>ResXFileCodeGenerator</Generator>
</EmbeddedResource>
</ItemGroup>

</Project>
82 changes: 0 additions & 82 deletions src/Microsoft.ComponentDetection.Common/Resources.Designer.cs
View file
Open in desktop

This file was deleted.

8 changes: 8 additions & 0 deletions src/Microsoft.ComponentDetection.Common/Resources.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
namespace Microsoft.ComponentDetection.Common;

internal static class Resources
{
internal const string MissingComponentId = "The component object does not have a componentId specified";

Comment thread
JamieMagee marked this conversation as resolved.
internal const string MissingNodeInDependencyGraph = "Node with id {0} has not be inserted in the dependency graph";
Comment thread
JamieMagee marked this conversation as resolved.
}
127 changes: 0 additions & 127 deletions src/Microsoft.ComponentDetection.Common/Resources.resx
View file
Open in desktop

This file was deleted.

Loading