Skip to content

Update framework package data#1454

Merged
grvillic merged 3 commits into
microsoft:mainfrom
ericstj:UpdateFrameworkPackages
Jul 23, 2025
Merged

Update framework package data#1454
grvillic merged 3 commits into
microsoft:mainfrom
ericstj:UpdateFrameworkPackages

Conversation

@ericstj

@ericstj ericstj commented Jul 22, 2025

Copy link
Copy Markdown
Member

Porting changes from
dotnet/sdk#49092
dotnet/sdk#49882

These improve the accuracy of the FrameworkPackages -- accounting for some packages which were removed from the shared framework, and representing the latest version of packages which were absorbed into the framework.

Porting changes from
dotnet/sdk#49092
dotnet/sdk#49882

These improve the accuracy of the FrameworkPackages -- accounting for
some packages which were removed from the shared framework, and
representing the latest version of packages which were absorbed into
the framework.
@ericstj ericstj requested review from dsplaisted and grvillic July 22, 2025 17:46
@ericstj ericstj requested a review from a team as a code owner July 22, 2025 17:46
@codecov

codecov Bot commented Jul 22, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.8%. Comparing base (92eea0e) to head (5ef3748).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1454   +/-   ##
=====================================
  Coverage   89.8%   89.8%           
=====================================
  Files        411     411           
  Lines      33061   33102   +41     
  Branches    2045    2046    +1     
=====================================
+ Hits       29709   29751   +42     
  Misses      2935    2935           
+ Partials     417     416    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericstj

ericstj commented Jul 23, 2025

Copy link
Copy Markdown
Member Author

@grvillic I think this should be ready to merge.

The failing build here seems to be complaining about perf.

  Failed CheckDetectorsRunTimesAndCounts [314 ms]
  Error Message:
   Expected newTime to be less than or equal to 61.995773F because Total Time take increased by a large amount. Please verify before continuing. old time: 35.426155, new time: 85.14904, but found 85.14904F (difference of 23.153267).

If I look at the report, the long-pole is not the nuget detector:

┌───────────────────┬───────────────────┬───────────────────┬──────────────────┐
│ Component         │ Detection Time    │ # Components      │ # Explicitly     │
│ Detector Id       │                   │ Found             │ Referenced       │
├───────────────────┼───────────────────┼───────────────────┼──────────────────┤
│ CocoaPods         │ 8.1 seconds       │ 1                 │ 1                │
│ DockerReference   │ 4.5 seconds       │ 6                 │ 0                │
│ DotNet            │ 29 seconds        │ 3                 │ 0                │
│ Go                │ 22 seconds        │ 2                 │ 0                │
│ Gradle            │ 8.1 seconds       │ 159               │ 0                │
│ Ivy (Beta)        │ 80 seconds        │ 11                │ 2                │
│ Linux             │ 0.49 seconds      │ 0                 │ 0                │
│ MvnCli            │ 85 seconds        │ 8                 │ 4                │
│ Npm               │ 4.6 seconds       │ 1                 │ 0                │
│ NpmLockfile3      │ 4.6 seconds       │ 147               │ 5                │
│ NpmWithRoots      │ 4.6 seconds       │ 147               │ 5                │
│ NuGet             │ 4.6 seconds       │ 1                 │ 0                │
│ NuGetPackagesConf │ 4.6 seconds       │ 63                │ 63               │
│ ig                │                   │                   │                  │
│ NuGetProjectCentr │ 4.6 seconds       │ 65                │ 2                │
│ ic                │                   │                   │                  │
│ PipReport         │ 82 seconds        │ 51                │ 37               │
│ Pnpm              │ 4.6 seconds       │ 148               │ 6                │
│ Poetry (Beta)     │ 4.6 seconds       │ 54                │ 0                │
│ Ruby              │ 4.6 seconds       │ 8                 │ 4                │
│ RustCli           │ 61 seconds        │ 11                │ 3                │
│ RustCrateDetector │ 4.6 seconds       │ 11                │ 3                │
│ RustSbom (Beta)   │ 4.6 seconds       │ 0                 │ 0                │
│ SPDX22SBOM        │ 4.5 seconds       │ 3                 │ 0                │
│ Vcpkg             │ 4.6 seconds       │ 6                 │ 0                │
│ Yarn              │ 4.6 seconds       │ 148               │ 5                │
│ ───────────────── │ ──────────────── │ ───────────────── │ ──────────────── │
│ Total             │ 85 seconds        │ 1054              │ 140              │
└───────────────────┴───────────────────┴───────────────────┴──────────────────┘

The culprit here seems to be PipReport │ 82 seconds

@grvillic grvillic merged commit e53a7eb into microsoft:main Jul 23, 2025
24 of 26 checks passed
@github-actions

Copy link
Copy Markdown

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants