Skip to content

Updates to the VCPKG detector to use manifest-info.json for resolving vcpkg.json location.#1436

Merged
grvillic merged 12 commits into
mainfrom
user/jdotson/vcpkgManifestFeature
Jun 20, 2025
Merged

Updates to the VCPKG detector to use manifest-info.json for resolving vcpkg.json location.#1436
grvillic merged 12 commits into
mainfrom
user/jdotson/vcpkgManifestFeature

Conversation

@jdotson166
Copy link
Copy Markdown
Contributor

This is an update to the VCPKG detector to enhance file location metadata resolution by checking vcpkg_installed/manifest-info.json or its fallback to accurately parse and assign vcpkg.json locations for dependencies.

Fixes #1408

@jdotson166 jdotson166 requested a review from a team as a code owner June 12, 2025 23:14
@jdotson166 jdotson166 requested a review from jcfiorenzano June 12, 2025 23:14
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 90.67797% with 11 lines in your changes missing coverage. Please review.

Project coverage is 89.6%. Comparing base (5289cf1) to head (711e4d9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...etection.Detectors/vcpkg/VcpkgComponentDetector.cs 85.5% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #1436    +/-   ##
======================================
  Coverage   89.6%   89.6%            
======================================
  Files        404     405     +1     
  Lines      32169   32284   +115     
  Branches    2003    2008     +5     
======================================
+ Hits       28830   28934   +104     
- Misses      2928    2938    +10     
- Partials     411     412     +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 13, 2025

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@jdotson166 jdotson166 marked this pull request as draft June 13, 2025 23:07
Comment thread src/Microsoft.ComponentDetection.Detectors/vcpkg/VcpkgComponentDetector.cs Outdated
Comment thread src/Microsoft.ComponentDetection.Detectors/vcpkg/VcpkgComponentDetector.cs Outdated
Comment thread src/Microsoft.ComponentDetection.Detectors/vcpkg/VcpkgComponentDetector.cs Outdated
Comment thread src/Microsoft.ComponentDetection.Detectors/vcpkg/VcpkgComponentDetector.cs Outdated
@jdotson166 jdotson166 closed this Jun 18, 2025
@jdotson166 jdotson166 reopened this Jun 18, 2025
@jdotson166 jdotson166 marked this pull request as ready for review June 18, 2025 21:46
@jdotson166 jdotson166 requested a review from grvillic June 19, 2025 17:20
Bump Detector version
@grvillic grvillic merged commit ee30155 into main Jun 20, 2025
23 of 26 checks passed
@grvillic grvillic deleted the user/jdotson/vcpkgManifestFeature branch June 20, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vcpkg detection enhancement to report vcpkg.json file

3 participants