User/aamaini/go sort requests#1432
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1432 +/- ##
======================================
Coverage 89.5% 89.6%
======================================
Files 404 404
Lines 31977 32169 +192
Branches 1994 2003 +9
======================================
+ Hits 28627 28829 +202
+ Misses 2935 2928 -7
+ Partials 415 412 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
grvillic
reviewed
Jun 11, 2025
grvillic
approved these changes
Jun 11, 2025
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
grvillic
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Go detector used to ignore child directories of already processed directories because
go listin parents already accounted for children.To keep parity with this behavior, Go Detector preprocesses go.mod, go.sum files in order of increasing depth and keeps track of already processed directories.
OnPrepareDetectionAsyncsorts all process requests in order of depth, fullname making it fully deterministic and stable sort.OnFileFoundAsyncnow tracks processed project roots if go.mod was successfully parsed and go version in it was >= 1.17