Ignore local package references when parsing go.mod at Go117#1421
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1421 +/- ##
=====================================
Coverage 89.7% 89.7%
=====================================
Files 407 407
Lines 32294 32380 +86
Branches 1990 2000 +10
=====================================
+ Hits 28991 29074 +83
- Misses 2879 2881 +2
- Partials 424 425 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
grvillic
approved these changes
Jun 5, 2025
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignoring local package references is at parity with go CLI.
Changes
GetAllReplacePathDirectivesAsync: This method makes a pass over the go.mod file to collect all replace directives that point to a local path.TryRegisterDependencyFromModLinenow skips a dependency if it is supposed to be pointing to a local path. It also logs it for investigation later.