don't throw if engines property is a string array#1400
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1400 +/- ##
=====================================
Coverage 89.6% 89.6%
=====================================
Files 401 401
Lines 31811 31875 +64
Branches 1966 1972 +6
=====================================
+ Hits 28528 28591 +63
Misses 2863 2863
- Partials 420 421 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JamieMagee
reviewed
May 5, 2025
JamieMagee
approved these changes
May 5, 2025
JamieMagee
approved these changes
May 5, 2025
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package.jsonfiles seen in the wild have had a string array instead of an object for theenginesproperty (example here). Because of this, anything that pulls in one of these variant packages will fail to generate components.While
enginesshould be an object, this PR allows for this alternate form to allow detection to continue.Fixes #1385