Skip to content

Fix integration tests with DotNet component type#1396

Merged
grvillic merged 1 commit into
mainfrom
users/grvillic/fixIntegrationTests
Apr 30, 2025
Merged

Fix integration tests with DotNet component type#1396
grvillic merged 1 commit into
mainfrom
users/grvillic/fixIntegrationTests

Conversation

@grvillic
Copy link
Copy Markdown
Collaborator

@grvillic grvillic commented Apr 29, 2025

Context

We recently promoted DotNet component detector. Out integration tests were broken but the PR wasn't blocked.

We need to revisit if we are disabling them due to non-deterministic detectors or something else, otherwise we should enforce those CI checks for PRs.

@grvillic grvillic requested a review from a team as a code owner April 29, 2025 23:50
@grvillic grvillic requested a review from FernandoRojo April 29, 2025 23:50
@grvillic grvillic enabled auto-merge (squash) April 29, 2025 23:51
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.6%. Comparing base (81e93c7) to head (578a6e4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1396   +/-   ##
=====================================
  Coverage   89.6%   89.6%           
=====================================
  Files        401     401           
  Lines      31820   31821    +1     
  Branches    1964    1964           
=====================================
+ Hits       28539   28540    +1     
  Misses      2863    2863           
  Partials     418     418           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grvillic grvillic merged commit 4e23dde into main Apr 30, 2025
25 checks passed
@grvillic grvillic deleted the users/grvillic/fixIntegrationTests branch April 30, 2025 00:15
@github-actions
Copy link
Copy Markdown

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants