Some optimizations for component detection#1384
Merged
Merged
Conversation
This reverts commit dc9be95.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1384 +/- ##
=======================================
- Coverage 89.6% 89.6% -0.1%
=======================================
Files 401 401
Lines 31821 31811 -10
Branches 1965 1966 +1
=======================================
- Hits 28539 28528 -11
Misses 2863 2863
- Partials 419 420 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mpysson
reviewed
Apr 18, 2025
mpysson
reviewed
Apr 18, 2025
mpysson
approved these changes
Apr 18, 2025
grvillic
reviewed
Apr 23, 2025
jcfiorenzano
approved these changes
Apr 25, 2025
jcfiorenzano
requested changes
Apr 25, 2025
Contributor
jcfiorenzano
left a comment
There was a problem hiding this comment.
Waiting just for the bump of the yarn detector version.
jcfiorenzano
approved these changes
May 1, 2025
grvillic
approved these changes
May 2, 2025
grvillic
approved these changes
May 2, 2025
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a large 1JS repository, we have ~38% performance improvement (71s => 44s)
Notable gains are obtained from:
For (1), it is possible because
OnFileFoundAsyncfor Yarn detector is thread safe. For (2), it is better to replace allsetmethods in properties toinit, but the latter is not available for netstandard.On large 1JS repository, the following show before and after for this command
on 1JS codespaces
Before
After
Other perf. gain can be obtained by doing the following:
Newtonsoft.JsonwithSystem.Text.Json