Skip to content

Fix Microsoft Git install to use releases API for latest, lts, and current versions #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markphip merged 4 commits into from
Sep 3, 2025
Merged

Fix Microsoft Git install to use releases API for latest, lts, and current versions #77

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b86cae
Initial plan
Copilot Sep 3, 2025
99d0063
Fix Microsoft Git install to use releases API for 'latest'
Copilot Sep 3, 2025
ba76547
Treat lts, current, and latest as synonyms using releases API
Copilot Sep 3, 2025
b08f4cd
Bump Microsoft Git version to 1.0.7
markphip Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions src/microsoft-git/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,25 @@ fi
# Partial version matching
if [ "$(echo "${GIT_VERSION}" | grep -o '\.' | wc -l)" != "2" ]; then
requested_version="${GIT_VERSION}"
version_list="$(curl -sSL -H "Accept: application/vnd.github.v3+json" "https://api.github.com/repos/microsoft/git/tags?per_page=100" | grep -oP '"name":\s*"v\K[0-9]+\.[0-9]+\.[0-9]+\.vfs\.[0-9]+\.[0-9]+"' | tr -d '"' | sort -rV)"
if [ "${requested_version}" = "latest" ] || [ "${requested_version}" = "lts" ] || [ "${requested_version}" = "current" ]; then
GIT_VERSION="$(echo "${version_list}" | head -n 1)"
if [ "${requested_version}" = "latest" ]; then
# For latest, use the releases API to get the actual latest release
GIT_VERSION="$(curl -sSL -H "Accept: application/vnd.github.v3+json" "https://api.github.com/repos/microsoft/git/releases/latest" | grep -oP '"tag_name":\s*"v\K[0-9]+\.[0-9]+\.[0-9]+\.vfs\.[0-9]+\.[0-9]+"' | tr -d '"')"
else
set +e
GIT_VERSION="$(echo "${version_list}" | grep -E -m 1 "^${requested_version//./\\.}([\\.\\s]|$)")"
set -e
# For other cases (lts, current, partial versions), use the existing tags logic
version_list="$(curl -sSL -H "Accept: application/vnd.github.v3+json" "https://api.github.com/repos/microsoft/git/tags?per_page=100" | grep -oP '"name":\s*"v\K[0-9]+\.[0-9]+\.[0-9]+\.vfs\.[0-9]+\.[0-9]+"' | tr -d '"' | sort -rV)"
if [ "${requested_version}" = "lts" ] || [ "${requested_version}" = "current" ]; then

@markphip markphip Sep 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot I think we can actually treat the values of lts and current as synonyms for latest and handle them all the same

Copilot AI Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion! I've simplified the logic to treat 'lts', 'current', and 'latest' as synonyms. All three now use the releases API to get the actual latest release, ensuring they all receive properly released versions instead of potentially unreleased development tags. This also reduces the branching complexity in the code.

Changed in commit ba76547.

GIT_VERSION="$(echo "${version_list}" | head -n 1)"
else
set +e
GIT_VERSION="$(echo "${version_list}" | grep -E -m 1 "^${requested_version//./\\.}([\\.\\s]|$)")"
set -e
fi
if [ -z "${GIT_VERSION}" ] || ! echo "${version_list}" | grep "^${GIT_VERSION//./\\.}$" > /dev/null 2>&1; then
echo "Invalid git version: ${requested_version}" >&2
exit 1
fi
fi
if [ -z "${GIT_VERSION}" ] || ! echo "${version_list}" | grep "^${GIT_VERSION//./\\.}$" > /dev/null 2>&1; then
if [ -z "${GIT_VERSION}" ]; then
echo "Invalid git version: ${requested_version}" >&2
exit 1
fi
Expand Down