Skip to content

[Security] Fix MEDIUM vulnerability: python.flask.security.xss.audit.direct-use-of-jinja2.direct-use-of-jinja2 #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orbisai0security wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Security] Fix MEDIUM vulnerability: python.flask.security.xss.audit.direct-use-of-jinja2.direct-use-of-jinja2 #488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 28 additions & 9 deletions app/helpers/llm_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
SpeechSynthesizer,
)
from azure.communication.callautomation.aio import CallAutomationClient
from jinja2 import Environment
import html
import string
from json_repair import repair_json
from pydantic import BaseModel, TypeAdapter
from pydantic._internal._typing_extra import eval_type_lenient
Expand All @@ -32,10 +33,30 @@
from app.models.message import ToolModel

T = TypeVar("T")
_jinja = Environment(
autoescape=True,
enable_async=True,
)


def _safe_format_string(template: str, **kwargs: Any) -> str:
"""
Safely format a string template with kwargs, escaping HTML entities to prevent XSS.

This replaces jinja2 template rendering with a safer approach using Python's
string.Template and HTML escaping.
"""
# Escape all string values to prevent XSS
escaped_kwargs = {}
for key, value in kwargs.items():
if isinstance(value, str):
escaped_kwargs[key] = html.escape(value)
else:
escaped_kwargs[key] = value

try:
# Use string.Template for safe substitution
template_obj = string.Template(template)
return template_obj.safe_substitute(**escaped_kwargs)
except (KeyError, ValueError):
# If template substitution fails, return the original template
return template


class Parameters(BaseModel):
Expand Down Expand Up @@ -290,7 +311,7 @@ async def _function_schema(
)

description = _remove_newlines(
await _jinja.from_string(dedent(f.__doc__ or "")).render_async(**kwargs)
_safe_format_string(dedent(f.__doc__ or ""), **kwargs)
) # Remove possible indentation, render the description, then remove newlines to avoid hallucinations
name = f.__name__
parameters: dict[str, object] = (
Expand Down Expand Up @@ -382,9 +403,7 @@ def _description(name: str, value: Annotated[type[Any], str] | type[Any]) -> str
schema["default"] = dv

schema["description"] = _remove_newlines(
await _jinja.from_string(dedent(_description(name, value))).render_async(
**kwargs
)
_safe_format_string(dedent(_description(name, value)), **kwargs)
) # Remove possible indentation, render the description, then remove newlines to avoid hallucinations

return schema
Expand Down