Hanging calc for some trig function calls

[divVerent]

Describe the bug

Some trig functions can cause a really slow (or maybe endless?) loop.

Steps To Reproduce

1. Switch to scientific mode.
2. Switch to RAD mode.
3. Type (0-9e9999).
4. Click Trigonometry then sin.

Expected behavior

Either an error, or the correct value of sin(-9 * 10^9999).

Screenshots

Device and Application Information

• OS Build: 10.0.26100.0
• Architecture: X64
• Application Version: 11.2607.0.0
• Region: en-US
• Dev Version Installed: False

Additional context

calculator/src/CalcManager/CEngine/scicomm.cpp

Line 1130 in 4fd3fc5

return m_currentVal >= m_maxTrigonometricNum;

This only checks against a positive bound of 1e100 - negative values totally ignore it.

In conjunction with this, scale2pi at

calculator/src/CalcManager/Ratpack/support.cpp

Line 506 in 4fd3fc5

void scale2pi(_Inout_ PRAT* px, uint32_t radix, int32_t precision)

seems O(n^3) with n being the number of digits of the input.

When trying smaller values, it seems to imply the above expression isn't an endless loop but will take about 15 minutes to run while calc is unresponsive. So not sure if this counts as a bug or not, but it seems there is intent to prevent this by blocking positive values above 1e100.

Requested Assignment
I'm just reporting this problem. I don't want to fix it.

[divVerent]

Bug is not also in old calc (win32calc.exe doesn't refuse either side of sin(HUGE), but after a few seconds it shows a dialog that the calculation may take long and asks the user to cancel - I count that as a win).

[divVerent]

Wait, I am wrong.

[Radians]
111 [sin] -> -0.864..., fine.
1e1000 [sin] -> 1 (really?...)
9e9999 [sin] -> calculator goes not responding, can be stopped
[CE]
111 [sin] -> calculator goes not responding, can be stopped
[C] [C] [C] [C] [C]
111 [sin] -> calculator goes not responding, can be stopped
1 / 2 = -> 0.5
1 / 3 = -> Overflow
1e100 = -> Overflow

I suspect old calc's interrupting logic doesn't actually work, which could explain why new calc doesn't have it.