fix(autogen-ext): fix tempdir lifecycle, cross-drive path check, url encoding, and migrate pickle to json - #8253
Open
Morendais (Morendais) wants to merge 1 commit into
Conversation
…encoding, and migrate pickle to json - DockerJupyterCodeExecutor: persist TemporaryDirectory on instance instead of immediately exiting context manager, clean up in stop() and __del__() - MarkdownFileBrowser: handle ValueError from os.path.commonpath when paths reside on different Windows drives - HttpTool: URL-encode path parameters before interpolation into request path - MemoryBank & StringSimilarityMap: replace pickle serialization with JSON, maintaining backward-compatible fallback for reading legacy pkl files - Add unit tests for MarkdownFileBrowser cross-drive validation and HttpTool path parameter URL encoding
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR addresses four reliability and data-handling improvements in
autogen-ext:TemporaryDirectoryobject on the instance (self._temp_dir) instead of an immediately exitedwithcontext manager block in__init__. Added explicit cleanup instop()and__del__().ValueErrorraised byos.path.commonpathwhen testing paths that reside on different Windows drives (e.g.,C:\vsD:\).urllib.parse.quote(str(v), safe="")on path parameters before string interpolation inrun()to avoid broken request URLs._string_similarity_map.pyand_memory_bank.pypersistence frompickleto human-readablejson(uid_text_dict.jsonanduid_memo_dict.json) while maintaining backwards-compatible fallback loading for existing.pklfiles.Related issue number
N/A
Checks
test_markdown_file_browser.pyandtest_path_params_url_encoding).