Skip to content

fix(autogen-ext): fix __unknown_models set difference and outdated docstrings (#8243) - #8246

Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
microsoft:mainfrom
ManoharPaturi:fix/unknown-models-mistral
Open

Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
microsoft:mainfrom
ManoharPaturi:fix/unknown-models-mistral

Conversation

@ManoharPaturi

Copy link
Copy Markdown

Description

Fixes #8243.

  1. In _message_transform.py, the previous assignment to __unknown_models accidentally overwrote the set difference calculation and failed to subtract __llama_models, leaving dead code in the initial assignment. This PR properly subtracts all known model families (__openai_models, __claude_models, __gemini_models, __llama_models, and __mistral_models).
  2. Updated the docstring example in _transformation/registry.py where register_transformer was missing the api argument.
  3. Updated the docstring example in _message_transform.py to reflect the current get_transformer API and return type.
  4. Added unit test test_unknown_models_excludes_known_families in test_openai_model_client.py.

Checklist

  • Tests pass
  • Lint passes (ruff check)
  • Signed-off commit with DCO

…cstrings (microsoft#8243)

Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 17, 2026 07:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

源码里的非致命小问题

2 participants