refactor(integration): extract MCPIntegrator.install#1245
Open
abhinavgautam01 wants to merge 1 commit intomicrosoft:mainfrom
Open
refactor(integration): extract MCPIntegrator.install#1245abhinavgautam01 wants to merge 1 commit intomicrosoft:mainfrom
abhinavgautam01 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…r_install Strangler-fig stage 1: move install orchestration into run_mcp_install() while keeping MCPIntegrator.install as the public entrypoint.
abhinavgautam01
requested review from
danielmeppiel and
sergio-sisternes-epam
as code owners
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1004
Description
This PR applies strangler-fig stage 1 for MCP install orchestration: the implementation of
MCPIntegrator.installis moved intorun_mcp_install()insrc/apm_cli/integration/mcp_integrator_install.py.MCPIntegrator.installremains a thin delegate so the public API and existing call sites stay the same.Motivation:
mcp_integrator.pyis dominated by a very largeinstallmethod; extracting it improves readability and makes later refactors safer without changing behavior.Compatibility: Imports inside
run_mcp_install()keep test patch targets working (e.g.apm_cli.integration.mcp_integrator._get_console,MCPIntegrator._install_for_runtime)._get_consolestays imported onmcp_integratorwithnoqaso patches that target that module attribute keep working.Type of change
Testing
After
uv sync --extra dev:Result: 265 passed.