Skip to content

Improve recommendations in ExtendedDeprecatedApis for strlen #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacob-ronstadt merged 3 commits into from
Jun 27, 2025
Merged

Improve recommendations in ExtendedDeprecatedApis for strlen #179

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5e6cfd
Improve replacement recommendations in ExtendedDeprecatedApis
NateD-MSFT Jun 25, 2025
606a3ec
Bump query version
NateD-MSFT Jun 25, 2025
de11ba9
Merge branch 'development' into user/natede/eda-explanation-fix
NateD-MSFT Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/drivers/general/queries/ExtendedDeprecatedApis/ExtendedDeprecatedApis.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
* security
* ca_ported
* @scope generic
* @query-version v1
* @query-version v2
*/

import cpp
Expand Down Expand Up @@ -323,7 +323,7 @@ class ExtendedDeprecatedCall extends Element {
or
name.matches("swprintf") and
replacement =
"swprintf_s StringCbPrintf, StringCbPrintf_l, StringCbPrintf_lEx, StringCbPrintf, StringCbPrintfEx"
"swprintf_s, StringCbPrintf, StringCbPrintf_l, StringCbPrintf_lEx, StringCbPrintf, StringCbPrintfEx"
or
name.matches("ualstrcpyW") and replacement = "None"
or
Expand Down Expand Up @@ -447,11 +447,11 @@ class ExtendedDeprecatedCall extends Element {
or
// Functions marked deprecated in C28750
(
name.matches("lstrlen") and replacement = "_tcslen"
name.matches("lstrlen") and replacement = "_tcslen if the data is trusted, or _tcsnlen or StringCchLength if the data is untrusted"
or
name.matches("lstrlenA") and replacement = "strlen"
name.matches("lstrlenA") and replacement = "strlen if the data is trusted, or strnlen or StringCchLengthA if the data is untrusted"
or
name.matches("lstrlenW") and replacement = "wcslen"
name.matches("lstrlenW") and replacement = "wcslen if the data is trusted, or wcsnlen or StringCchLengthW if the data is untrusted"
)

or
Expand Down