Skip to content

Must run query update #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacob-ronstadt merged 6 commits into from
May 9, 2025
Merged

Must run query update #173

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a5c890c
Revert must-fix to current requirements. Make recommended contain wha…
jacob-ronstadt Apr 24, 2025
f96ac19
update version
jacob-ronstadt May 2, 2025
b3c9840
remove old suite files
jacob-ronstadt May 6, 2025
f1933e7
update dependency versions. update dvl_tests.ps1 for changed mustfix …
jacob-ronstadt May 7, 2025
0ad0a63
fix version number in suites
jacob-ronstadt May 7, 2025
dc08993
update qlpack version
jacob-ronstadt May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/qlpack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Licensed under the MIT license.

name: microsoft/windows-drivers
version: 1.5.0
version: 1.5.1
Comment thread
jacob-ronstadt marked this conversation as resolved.
Outdated
dependencies:
codeql/cpp-all: 4.0.0
microsoft/cpp-queries: 0.0.2
Expand Down
25 changes: 1 addition & 24 deletions src/windows-driver-suites/mustfix.qls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,30 +14,7 @@
- include:
query path:
- Likely Bugs/Arithmetic/BadAdditionOverflowCheck.ql
- Likely Bugs/Format/WrongNumberOfFormatArguments.ql
- Likely Bugs/Memory Management/PointerOverflow.ql
- Likely Bugs/Memory Management/SuspiciousCallToStrncat.ql
- Likely Bugs/OO/UnsafeUseOfThis.ql
- Likely Bugs/Protocols/TlsSettingsMisconfiguration.ql
- Likely Bugs/Protocols/UseOfDeprecatedHardcodedProtocol.ql
- Likely Bugs/Underspecified Functions/TooFewArguments.ql
- Microsoft/Likely Bugs/Conversion/BadOverflowGuard.ql
- Microsoft/Likely Bugs/Drivers/IncorrectUsageOfRtlCompareMemory.ql
- Microsoft/Security/Cryptography/BannedEncryption.ql
- Microsoft/Security/Cryptography/BannedModesCAPI.ql
- Microsoft/Security/Cryptography/BannedModesCNG.ql
- Microsoft/Security/Cryptography/HardcodedIVCNG.ql
- Microsoft/Security/MemoryAccess/EnumIndex/UncheckedBoundsEnumAsIndex.ql
- Security/CWE/CWE-078/ExecTainted.ql
- Security/CWE/CWE-114/UncontrolledProcessOperation.ql
- Security/CWE/CWE-120/BadlyBoundedWrite.ql
- Security/CWE/CWE-120/OverrunWrite.ql
- Security/CWE/CWE-131/NoSpaceForZeroTerminator.ql
- Security/CWE/CWE-170/ImproperNullTerminationTainted.ql
- Security/CWE/CWE-190/ComparisonWithWiderType.ql
- Security/CWE/CWE-253/HResultBooleanConversion.ql
- Security/CWE/CWE-327/OpenSslHeartbleed.ql
- Security/CWE/CWE-676/DangerousFunctionOverflow.ql
- Security/CWE/CWE-676/DangerousUseOfCin.ql
- Security/CWE/CWE-704/WcharCharConversion.ql
- Security/CWE/CWE-732/UnsafeDaclSecurityDescriptor.ql
- Security/CWE/CWE-253/HResultBooleanConversion.ql
5 changes: 5 additions & 0 deletions src/windows-driver-suites/mustrun.qls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Copyright (c) Microsoft Corporation.
# Licensed under the MIT license.

- description: Must-run queries for Windows Drivers.
- import: windows-driver-suites/recommended.qls #recommended includes mustfix
92 changes: 23 additions & 69 deletions src/windows-driver-suites/recommended.qls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,77 +3,31 @@

- description: Recommended and required queries for Windows Drivers.
- import: windows-driver-suites/mustfix.qls
- queries: .
from: microsoft/windows-drivers
- include:
query path:
- drivers/general/queries/AnnotationSyntax/AnnotationSyntax.ql
- drivers/general/queries/CurrentFunctionTypeNotCorrect/CurrentFunctionTypeNotCorrect.ql
- drivers/general/queries/DefaultPoolTag/DefaultPoolTag.ql
- drivers/general/queries/DriverEntrySaveBuffer/DriverEntrySaveBuffer.ql
- drivers/general/queries/ExaminedValue/ExaminedValue.ql
- drivers/general/queries/ExtendedDeprecatedApis/ExtendedDeprecatedApis.ql
- drivers/general/queries/IRPStackEntryCopy/IRPStackEntryCopy.ql
- drivers/general/queries/ImportantFunctionCallOptimizedOut/ImportantFunctionCallOptimizedOut.ql
- drivers/general/queries/ImproperNotOperatorOnZero/ImproperNotOperatorOnZero.ql
- drivers/general/queries/InvalidFunctionClassTypedef/InvalidFunctionClassTypedef.ql
- drivers/general/queries/InvalidFunctionPointerAnnotation/InvalidFunctionPointerAnnotation.ql
- drivers/general/queries/IoInitializeTimerCall/IoInitializeTimerCall.ql
- drivers/general/queries/IrqlAnnotationIssue/IrqlAnnotationIssue.ql
- drivers/general/queries/IrqlCancelRoutine/IrqlCancelRoutine.ql
- drivers/general/queries/IrqlFloatStateMismatch/IrqlFloatStateMismatch.ql
- drivers/general/queries/IrqlNotSaved/IrqlNotSaved.ql
- drivers/general/queries/IrqlNotUsed/IrqlNotUsed.ql
- drivers/general/queries/IrqlSetTooHigh/IrqlSetTooHigh.ql
Comment thread
jacob-ronstadt marked this conversation as resolved.
- drivers/general/queries/IrqlSetTooLow/IrqlSetTooLow.ql
- drivers/general/queries/IrqlTooHigh/IrqlTooHigh.ql
- drivers/general/queries/IrqlTooLow/IrqlTooLow.ql
- drivers/general/queries/KeSetEventPageable/KeSetEventPageable.ql
- drivers/general/queries/MultithreadedAVCondition/MultithreadedAVCondition.ql
- drivers/general/queries/NtstatusExplicitCast/NtstatusExplicitCast.ql
- drivers/general/queries/NtstatusExplicitCast2/NtstatusExplicitCast2.ql
- drivers/general/queries/NtstatusExplicitCast3/NtstatusExplicitCast3.ql
- drivers/general/queries/NullCharacterPointerAssignment/NullCharacterPointerAssignment.ql
- drivers/general/queries/OperandAssignment/OperandAssignment.ql
- drivers/general/queries/PointerVariableSize/PointerVariableSize.ql
- drivers/general/queries/PoolTagIntegral/PoolTagIntegral.ql
- drivers/general/queries/RoleTypeCorrectlyUsed/RoleTypeCorrectlyUsed.ql
- drivers/general/queries/RoutineFunctionTypeNotExpected/RoutineFunctionTypeNotExpected.ql
- drivers/general/queries/StrSafe/StrSafe.ql
- drivers/general/queries/StrictTypeMatch/StrictTypeMatch.ql
- drivers/wdm/queries/IllegalFieldAccess/IllegalFieldAccess.ql
- drivers/wdm/queries/IllegalFieldAccess2/IllegalFieldAccess2.ql
- drivers/wdm/queries/IllegalFieldWrite/IllegalFieldWrite.ql
- drivers/wdm/queries/InitNotCleared/InitNotCleared.ql
- drivers/wdm/queries/KeWaitLocal/KeWaitLocal.ql
- drivers/wdm/queries/MultiplePagedCode/MultiplePagedCode.ql
- drivers/wdm/queries/ObReferenceMode/ObReferenceMode.ql
- drivers/wdm/queries/OpaqueMdlUse/OpaqueMdlUse.ql
- drivers/wdm/queries/OpaqueMdlWrite/OpaqueMdlWrite.ql
- drivers/wdm/queries/PendingStatusError/PendingStatusError.ql
- drivers/wdm/queries/WrongDispatchTableAssignment/WrongDispatchTableAssignment.ql
- microsoft/Likely Bugs/Boundary Violations/PaddingByteInformationDisclosure.ql
- microsoft/Likely Bugs/Conversion/BadOverflowGuard.ql
- microsoft/Likely Bugs/Conversion/InfiniteLoop.ql
- microsoft/Likely Bugs/Memory Management/UseAfterFree/UseAfterFree.ql
- microsoft/Likely Bugs/UninitializedPtrField.ql
- microsoft/Security/Crytpography/HardcodedIVCNG.ql
- queries: .
from: microsoft/cpp-queries
version: 0.0.2
- include:
query path:
- Best Practices/Likely Errors/OffsetUseBeforeRangeCheck.ql
- Likely Bugs/Arithmetic/IntMultToLong.ql
- Likely Bugs/Arithmetic/SignedOverflowCheck.ql
- Likely Bugs/Conversion/CastArrayPointerArithmetic.ql
- Likely Bugs/Likely Typos/IncorrectNotOperatorUsage.ql
- Likely Bugs/Memory Management/SuspiciousSizeof.ql
- Likely Bugs/Memory Management/UninitializedLocal.ql
- Security/CWE/CWE-121/UnterminatedVarargsCall.ql
- Security/CWE/CWE-457/ConditionallyUninitializedVariable.ql
- Security/CWE/CWE-468/SuspiciousAddWithSizeof.ql
- Security/CWE/CWE-468/IncorrectPointerScaling.ql
- Security/CWE/CWE-468/IncorrectPointerScalingVoid.ql
- Security/CWE/CWE-676/PotentiallyDangerousFunction.ql
- Security/CWE/CWE-119/OverflowBuffer.ql
- Likely Bugs/Format/WrongNumberOfFormatArguments.ql
- Likely Bugs/Memory Management/SuspiciousCallToStrncat.ql
- Likely Bugs/OO/UnsafeUseOfThis.ql
- Likely Bugs/Protocols/TlsSettingsMisconfiguration.ql
- Likely Bugs/Protocols/UseOfDeprecatedHardcodedProtocol.ql
- Microsoft/Likely Bugs/Conversion/BadOverflowGuard.ql
- Microsoft/Likely Bugs/Drivers/IncorrectUsageOfRtlCompareMemory.ql
- Microsoft/Security/Cryptography/BannedEncryption.ql
- Microsoft/Security/Cryptography/BannedModesCAPI.ql
- Microsoft/Security/Cryptography/BannedModesCNG.ql
- Microsoft/Security/Cryptography/HardcodedIVCNG.ql
- Microsoft/Security/MemoryAccess/EnumIndex/UncheckedBoundsEnumAsIndex.ql
- Security/CWE/CWE-078/ExecTainted.ql
- Security/CWE/CWE-114/UncontrolledProcessOperation.ql
- Security/CWE/CWE-120/BadlyBoundedWrite.ql
- Security/CWE/CWE-120/OverrunWrite.ql
- Security/CWE/CWE-131/NoSpaceForZeroTerminator.ql
- Security/CWE/CWE-170/ImproperNullTerminationTainted.ql
- Security/CWE/CWE-327/OpenSslHeartbleed.ql
- Security/CWE/CWE-676/DangerousFunctionOverflow.ql
- Security/CWE/CWE-676/DangerousUseOfCin.ql
- Security/CWE/CWE-704/WcharCharConversion.ql
- Security/CWE/CWE-732/UnsafeDaclSecurityDescriptor.ql