Skip to content

Commit df3da19

Browse files
authored
Improve recommendations in ExtendedDeprecatedApis for strlen (#179)
* Improve replacement recommendations in ExtendedDeprecatedApis * Bump query version
1 parent 35d8ba7 commit df3da19

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

src/drivers/general/queries/ExtendedDeprecatedApis/ExtendedDeprecatedApis.ql

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
* security
1919
* ca_ported
2020
* @scope generic
21-
* @query-version v1
21+
* @query-version v2
2222
*/
2323

2424
import cpp
@@ -323,7 +323,7 @@ class ExtendedDeprecatedCall extends Element {
323323
or
324324
name.matches("swprintf") and
325325
replacement =
326-
"swprintf_s StringCbPrintf, StringCbPrintf_l, StringCbPrintf_lEx, StringCbPrintf, StringCbPrintfEx"
326+
"swprintf_s, StringCbPrintf, StringCbPrintf_l, StringCbPrintf_lEx, StringCbPrintf, StringCbPrintfEx"
327327
or
328328
name.matches("ualstrcpyW") and replacement = "None"
329329
or
@@ -447,11 +447,11 @@ class ExtendedDeprecatedCall extends Element {
447447
or
448448
// Functions marked deprecated in C28750
449449
(
450-
name.matches("lstrlen") and replacement = "_tcslen"
450+
name.matches("lstrlen") and replacement = "_tcslen if the data is trusted, or _tcsnlen or StringCchLength if the data is untrusted"
451451
or
452-
name.matches("lstrlenA") and replacement = "strlen"
452+
name.matches("lstrlenA") and replacement = "strlen if the data is trusted, or strnlen or StringCchLengthA if the data is untrusted"
453453
or
454-
name.matches("lstrlenW") and replacement = "wcslen"
454+
name.matches("lstrlenW") and replacement = "wcslen if the data is trusted, or wcsnlen or StringCchLengthW if the data is untrusted"
455455
)
456456

457457
or

0 commit comments

Comments
 (0)