Skip to content

Commit 35d8ba7

Browse files
Fix query health action (#177)
* suppress breaking change warning. NA because we don't get the output from set-azstoragefilecontent * move float safe/unsafe queries to kmdf folder and fix output strings * move float safe/unsafe queries to kmdf folder and fix output strings
1 parent 35b9f55 commit 35d8ba7

11 files changed

Lines changed: 1194 additions & 905 deletions

File tree

.github/workflows/build-codeql.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ jobs:
132132
with:
133133
azPSVersion: latest
134134
inlineScript: |
135+
Update-AzConfig -DisplayBreakingChangeWarning $false
135136
$context = New-AzStorageContext -StorageAccountName "$env:ACCOUNT_NAME" -UseConnectedAccount -EnableFileBackupRequestIntent
136137
Set-AzStorageFileContent -ShareName "$env:SHARE_NAME" -Source "diffdetailedfunctiontestresults.xlsx" -Path "health-diffdetailedfunctiontestresults.xlsx" -Context $context
137138
exit 1

src/drivers/general/queries/FloatSafeExit/FloatSafeExit.sarif

Lines changed: 0 additions & 367 deletions
This file was deleted.

src/drivers/general/queries/FloatUnsafeExit/FloatUnsafeExit.sarif

Lines changed: 0 additions & 534 deletions
This file was deleted.

src/drivers/general/queries/FloatSafeExit/FloatSafeExit.qhelp renamed to src/drivers/kmdf/queries/FloatSafeExit/FloatSafeExit.qhelp

File renamed without changes.

src/drivers/general/queries/FloatSafeExit/FloatSafeExit.ql renamed to src/drivers/kmdf/queries/FloatSafeExit/FloatSafeExit.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,13 @@ where
8989
safeFloatRestoreFuncCall.getEnclosingFunction() = kernelFloatFunc
9090
) and
9191
msg =
92-
"Function annotated with _Kernel_float_restored_ but does not call a safe float access function for some path(s)"
92+
"Function annotated with _Kernel_float_restored_ but may not call/check return value of a safe float access function for some path(s)"
9393
or
9494
// Paths have call to safe float access function but return value is not used
9595
unusedFc instanceof SafeFloatRestoreFuncCall and
9696
unusedFc.getEnclosingFunction() = kernelFloatFunc and
9797
msg =
98-
"Function annotated with _Kernel_float_restored_ but does not check a safe float access function return value for some path(s)" and
98+
"Function annotated with _Kernel_float_restored_ but may not call/check return value of a safe float access function for some path(s)" and
9999
(
100100
// return value isn't used at all
101101
unused(unusedFc)

src/drivers/kmdf/queries/FloatSafeExit/FloatSafeExit.sarif

Lines changed: 610 additions & 0 deletions
Large diffs are not rendered by default.

src/drivers/general/queries/FloatSafeExit/driver_snippet.c renamed to src/drivers/kmdf/queries/FloatSafeExit/driver_snippet.c

File renamed without changes.

src/drivers/general/queries/FloatUnsafeExit/FloatUnsafeExit.qhelp renamed to src/drivers/kmdf/queries/FloatUnsafeExit/FloatUnsafeExit.qhelp

File renamed without changes.

src/drivers/general/queries/FloatUnsafeExit/FloatUnsafeExit.ql renamed to src/drivers/kmdf/queries/FloatUnsafeExit/FloatUnsafeExit.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,13 +81,13 @@ where
8181
safeFloatAccessFuncCall.getEnclosingFunction() = kernelFloatFunc
8282
) and
8383
msg =
84-
"Function annotated with _Kernel_float_saved_ but does not call a safe float access function for some path(s)"
84+
"Function annotated with _Kernel_float_saved_ but may not call/check return values of safe float access function for some path(s)"
8585
or
8686
// Paths have call to safe float access function but return value is not used
8787
unusedFc instanceof SafeFloatAccessFuncCall and
8888
unusedFc.getEnclosingFunction() = kernelFloatFunc and
8989
msg =
90-
"Function annotated with _Kernel_float_saved_ but does not check a safe float access function return value for some path(s)" and
90+
"Function annotated with _Kernel_float_saved_ but may not call/check return values of safe float access function for some path(s)" and
9191
(
9292
// return value isn't used at all
9393
unused(unusedFc)

src/drivers/kmdf/queries/FloatUnsafeExit/FloatUnsafeExit.sarif

Lines changed: 579 additions & 0 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)