Skip to content

[Shortcut Guide] Guard against null AppWindow in SetWindowPosition #48870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
niels9001 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Draft

[Shortcut Guide] Guard against null AppWindow in SetWindowPosition #48870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/modules/ShortcutGuide/ShortcutGuide.Ui/ShortcutGuideXAML/MainWindow.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,16 @@ private void SetWindowPosition()
{
try
{
// During the reentrant Hide -> Activate -> BringToFront chain triggered from
// section selection, this window's own AppWindow can briefly be null. Any WinUIEx
// size access below (e.g. MaxHeight -> get_Height) would dereference it and throw an
// NRE from inside WinUIEx (issue #48773). Skip this pass and keep the previous layout;
// a later AppWindow.Changed / Activated event reruns this once the window settles.
if (AppWindow is null)
{
return;
}

if (!this._hasMovedToRightMonitor)
{
NativeMethods.GetCursorPos(out NativeMethods.POINT lpPoint);
Expand Down
Loading