[PowerDisplay] Add setting for mouse wheel increment on slider controls#48809
Open
giruuuuj wants to merge 3 commits into
Open
[PowerDisplay] Add setting for mouse wheel increment on slider controls#48809giruuuuj wants to merge 3 commits into
giruuuuj wants to merge 3 commits into
Conversation
…ls (microsoft#48805) Adds a configurable mouse_wheel_change setting (default 5, range 1-25) so users can control how much brightness, contrast, and volume sliders change per mouse wheel notch. Changes: - PowerDisplayProperties: add MouseWheelChange property (default 5) - MainWindow.xaml: bind slider MouseWheelChange to ViewModel instead of hardcoded 5 - MainViewModel: expose MouseWheelChange observable property, load from settings - MonitorViewModel: forward MouseWheelChange from parent MainViewModel - PowerDisplayViewModel (Settings): add MouseWheelChange property with IPC signal - PowerDisplayPage.xaml: add NumberBox (1-25) for mouse wheel increment - Resources.resw: add en-us localization strings
github-actions
Bot
added
Area-Localization
Collaborator
|
@giruuuuj Can you please post a screenrecording of the new behavior? Thanks |
Contributor
|
Please run xaml script to fix the style bug. |
Migrates the Quick Accent module from WPF (PowerAccent.UI) to WinUI3, following the Image Resizer migration as the reference pattern. ### Changes **PowerAccent.Core** (class library - no more WPF/WinForms dependencies): - Removed <UseWPF> and <UseWindowsForms> from .csproj - Replaced System.Windows.Application.Current.Dispatcher.Invoke() with injected Action<Action> dispatcher delegate - Replaced System.Windows.Forms.SendKeys with native PInvoke.SendInput - Added WindowsFunctions.SendVirtualKey() for VK_LEFT/VK_RIGHT input **PowerAccent.UI** (WinUI3 project - was WPF): - Rewrote .csproj: <UseWPF> -> <UseWinUI>, WinAppSDK + WinUIEx refs - Rewrote App.xaml + App.xaml.cs: WinUI3 Application with XamlControlsResources - Rewrote Program.cs: WinUI3 Application.Start() with DispatcherQueueSynchronizationContext - Created MainWindow.xaml + .cs: WinUI3 WindowEx with DesktopAcrylicBackdrop, ListView (horizontal), native WS_EX_NOACTIVATE/TOOLWINDOW styles, AppWindow-based show/hide/topmost/positioning - Deleted Selector.xaml, Selector.xaml.cs, AssemblyInfo.cs (WPF-only) ### Architecture notes - Window overlay uses native win32 extended styles (WS_EX_NOACTIVATE, WS_EX_TOOLWINDOW, WS_EX_TRANSPARENT) instead of WPF AllowsTransparency - DesktopAcrylicBackdrop provides modern Windows 11 acrylic background - Per-pixel transparency gap is avoided by using native DWM rounded corners - Dispatcher injection pattern allows Core library to remain framework-agnostic
|
Thank you for contributing to PowerToys. We've detected that this PR might include a new or modified telemetry event. Please ensure the following before merging:
|
niels9001
added
the
Needs-Author-Feedback
Collaborator
|
@giruuuuj Accept the Microsoft GitHub Policy Service and post a screenrecording of the new behavior. Without it we will not continue reviewing this PR |
Contributor
Author
|
@microsoft-github-policy-service agree |
microsoft-github-policy-service
Bot
added
Needs-Triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds a configurable mouse_wheel_change setting so users can control how much brightness, contrast, and volume sliders change per mouse wheel notch (default 5, range 1-25).
Detailed Description of the Pull Request / Additional Comments
Previously the mouse wheel increment was hardcoded to 5 in the XAML. This PR adds it as a user-configurable setting in PowerToys Settings.
Changes:
Closes
#48805