Skip to content

feat(shortcut-guide): add 1Password manifest#48793

Open
brycewc wants to merge 2 commits into
microsoft:mainfrom
brycewc:shortcut-guide-1password
Open

feat(shortcut-guide): add 1Password manifest#48793
brycewc wants to merge 2 commits into
microsoft:mainfrom
brycewc:shortcut-guide-1password

Conversation

@brycewc

@brycewc brycewc commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary of the Pull Request

Adds a Shortcut Guide manifest for the 1Password desktop app.

  • New manifest: src/modules/ShortcutGuide/ShortcutGuide.Ui/Assets/ShortcutGuide/Manifests/AgileBits.1Password.en-US.yml: 26 shortcuts for 1Password.exe, grouped into the same four sections 1Password uses in its in-app Keyboard Shortcuts reference:
    • Basics: View keyboard shortcuts, Show Quick Access, Lock 1Password
    • Navigation: Find, Switch to all accounts, Switch accounts & collections, Back, Forward, Focus next/previous row, Focus right/left section
    • Selected item: Copy primary field / password / one-time password, Open & fill in web browser, Open item in new window, Edit item, Save item, Reveal concealed fields, Archive item, Delete item
    • View: Show/hide sidebar, Zoom in, Zoom out, Actual size
  • No code changes. The manifest is auto-included via the existing Manifests/*.yml glob in ShortcutGuide.Ui.csproj, exactly like the existing Postman, Slack, Discord, and browser manifests.
  • The two literal-digit shortcuts (Ctrl+1 switch to all accounts, Ctrl+0 actual size) use the <N> token (<1> / <0>) per the manifest spec, and the "Switch accounts & collections" range renders as 2 - 9.
  • Documentation: Added a note in doc/specs/WinGet Manifest Keyboard Shortcuts schema.md documenting the existing sentence-case naming convention for Name and SectionName (capitalize only the first word plus proper nouns / product feature names), so future contributors do not copy an application's title-case shortcut-list styling. The 1Password names in this PR follow that convention, keeping only feature/product names capitalized (Show Quick Access, Lock 1Password).

PR Checklist

  • Closes: Add 1Password keyboard shortcuts to Shortcut Guide #48792
  • Communication: I've discussed this with core contributors already.
  • Tests: Added/updated and all pass
  • Localization: All end-user-facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated:
  • Local run: Built the Shortcut Guide projects and ran the Debug build with 1Password focused (Win+Shift+/); screenshot of the rendered guide is attached below.

Detailed Description of the Pull Request / Additional comments

The Shortcut Guide displays per-app shortcuts from YAML manifests, matched to the foreground window via WindowFilter. Adding support for an app is purely additive: drop a <PackageName>.<locale>.yml file in the Manifests folder and it is picked up by the existing build glob and the index generator.

  • PackageName: AgileBits.1Password (the WinGet package identifier) and WindowFilter: "1Password.exe" (the desktop app process).
  • Name: 1Password is the display name shown in the Shortcut Guide app picker.
  • Shortcut names follow the repo's sentence-case convention (now documented in the schema spec). Recommended is set on the five highest-frequency / signature actions: Show Quick Access, Lock 1Password, Copy primary field, Copy password, Copy one-time password.

Validation Steps Performed

  • Schema/parse: Deserialized the manifest with YamlDotNet.Serialization.Deserializer (the same path ManifestInterpreter.YamlToShortcutList uses). All four sections and 26 entries parse, with 5 marked Recommended. No parse errors.
  • Key rendering: Verified every key token against KeyVisual and ShortcutDescriptionToKeysConverter: <Space>/<Delete> strip to their labels, <Left>/<Right>/<Up>/<Down> map to arrow glyphs, <1>/<0> strip to the literal digit (matching the merged Postman <9>/<0> handling), 2 - 9 renders verbatim, and + / - render as the literal symbols (as in the bundled Windows Explorer and Shell manifests).
  • Source fidelity: The section grouping and every shortcut/modifier combination match 1Password's in-app Keyboard Shortcuts reference one-to-one.

🤖 Generated with Claude Code

image

Add a Shortcut Guide manifest for the 1Password desktop app
(AgileBits.1Password, 1Password.exe), covering the shortcuts from
1Password's in-app Keyboard Shortcuts reference: Basics, Navigation,
Selected Item, and View (26 shortcuts total).

Auto-included via the existing Manifests/*.yml glob in
ShortcutGuide.Ui.csproj, so no code changes are required. Literal digit
keys (Ctrl+1, Ctrl+0) use the <N> token per the manifest spec.

Closes microsoft#48792

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added the Product-Shortcut Guide Refers to the Shortcut Guide PowerToy label Jun 22, 2026
Rename the 1Password manifest's section and shortcut names from title
case to sentence case, matching the convention used by every other
bundled manifest (capitalize only the first word plus proper nouns and
product/feature names). "Show Quick Access", "Lock 1Password", and
"Switch accounts & collections" keep their feature/product casing.

Also document the sentence-case convention under the Name and
SectionName fields in the manifest schema spec so future contributors
do not copy an application's title-case shortcut-list styling.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@niels9001 niels9001 requested a review from noraa-junker June 23, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Product-Shortcut Guide Refers to the Shortcut Guide PowerToy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add 1Password keyboard shortcuts to Shortcut Guide

1 participant