feat(shortcut-guide): add 1Password manifest#48793
Open
brycewc wants to merge 2 commits into
Open
Conversation
Add a Shortcut Guide manifest for the 1Password desktop app (AgileBits.1Password, 1Password.exe), covering the shortcuts from 1Password's in-app Keyboard Shortcuts reference: Basics, Navigation, Selected Item, and View (26 shortcuts total). Auto-included via the existing Manifests/*.yml glob in ShortcutGuide.Ui.csproj, so no code changes are required. Literal digit keys (Ctrl+1, Ctrl+0) use the <N> token per the manifest spec. Closes microsoft#48792 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Rename the 1Password manifest's section and shortcut names from title case to sentence case, matching the convention used by every other bundled manifest (capitalize only the first word plus proper nouns and product/feature names). "Show Quick Access", "Lock 1Password", and "Switch accounts & collections" keep their feature/product casing. Also document the sentence-case convention under the Name and SectionName fields in the manifest schema spec so future contributors do not copy an application's title-case shortcut-list styling. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds a Shortcut Guide manifest for the 1Password desktop app.
src/modules/ShortcutGuide/ShortcutGuide.Ui/Assets/ShortcutGuide/Manifests/AgileBits.1Password.en-US.yml: 26 shortcuts for1Password.exe, grouped into the same four sections 1Password uses in its in-app Keyboard Shortcuts reference:Manifests/*.ymlglob inShortcutGuide.Ui.csproj, exactly like the existing Postman, Slack, Discord, and browser manifests.Ctrl+1switch to all accounts,Ctrl+0actual size) use the<N>token (<1>/<0>) per the manifest spec, and the "Switch accounts & collections" range renders as2 - 9.doc/specs/WinGet Manifest Keyboard Shortcuts schema.mddocumenting the existing sentence-case naming convention forNameandSectionName(capitalize only the first word plus proper nouns / product feature names), so future contributors do not copy an application's title-case shortcut-list styling. The 1Password names in this PR follow that convention, keeping only feature/product names capitalized (Show Quick Access, Lock 1Password).PR Checklist
Win+Shift+/); screenshot of the rendered guide is attached below.Detailed Description of the Pull Request / Additional comments
The Shortcut Guide displays per-app shortcuts from YAML manifests, matched to the foreground window via
WindowFilter. Adding support for an app is purely additive: drop a<PackageName>.<locale>.ymlfile in theManifestsfolder and it is picked up by the existing build glob and the index generator.PackageName: AgileBits.1Password(the WinGet package identifier) andWindowFilter: "1Password.exe"(the desktop app process).Name: 1Passwordis the display name shown in the Shortcut Guide app picker.Validation Steps Performed
YamlDotNet.Serialization.Deserializer(the same pathManifestInterpreter.YamlToShortcutListuses). All four sections and 26 entries parse, with 5 marked Recommended. No parse errors.KeyVisualandShortcutDescriptionToKeysConverter:<Space>/<Delete>strip to their labels,<Left>/<Right>/<Up>/<Down>map to arrow glyphs,<1>/<0>strip to the literal digit (matching the merged Postman<9>/<0>handling),2 - 9renders verbatim, and+/-render as the literal symbols (as in the bundled Windows Explorer and Shell manifests).🤖 Generated with Claude Code