CmdPal: Fix fallback results showing when disabled in Command Palette#48777
Open
michaeljolley wants to merge 1 commit into
Open
CmdPal: Fix fallback results showing when disabled in Command Palette#48777michaeljolley wants to merge 1 commit into
michaeljolley wants to merge 1 commit into
Conversation
When a fallback command is disabled, it should not appear in search results. Previously, disabled fallbacks that were not in the configured global fallbacks list would still be added to commonFallbacks and shown in search results. The fix adds an IsEnabled check when building the commonFallbacks list, ensuring disabled fallback commands are excluded from results. Fixes #48504 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
michaeljolley
added
the
Product-Command Palette
michaeljolley
added
the
Needs-Review
michaeljolley
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fallback results were showing in Command Palette search results even when the user had disabled them in settings.
When a fallback command is disabled (e.g., VS Code for Command Palette with
IsEnabled = false), it is excluded fromconfiguredGlobalFallbackIds(which only contains enabled + global fallbacks). However, during search filtering, all fallbacks NOT inconfiguredGlobalFallbackIdswere unconditionally added tocommonFallbacks, which gets scored and displayed in results. This means disabled fallbacks still appeared.To fix, I added an
IsEnabledcheck when building thecommonFallbackslist inMainListPage.cs. Disabled fallback commands are now properly excluded from search results.Fixes #48504