Closed
ZoomIt: Make secondary hotkeys independently configurable#47411
Conversation
Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/08f8b57d-1451-4af8-87e7-3c5a362b1bd8 Co-authored-by: MuyuanMS <116717757+MuyuanMS@users.noreply.github.com>
…log behavior and restore DemoType reset info in FAQ Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/08f8b57d-1451-4af8-87e7-3c5a362b1bd8 Co-authored-by: MuyuanMS <116717757+MuyuanMS@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix key binds clash between Zoomit and Windows Terminal
ZoomIt: Make secondary hotkeys independently configurable
Apr 29, 2026
Contributor
|
Closing AI generated PR as for this issue as it requires more designs with UI involved |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
ZoomIt's secondary hotkeys (Live drawing, Record portion/window, Snip save, Panorama save, DemoType reset) were hardcoded as XOR-derived variants of their primary keys (e.g., Ctrl+Shift+4/5/6), making them impossible to reassign. This clashed with Windows Terminal's Ctrl+Shift+1–9 profile-switching shortcuts and any other apps using those combinations.
All 6 secondary hotkeys are now independently configurable via the PowerToys Settings UI, with defaults matching the previous derived values (fully backward-compatible).
PR Checklist
Detailed Description of the Pull Request / Additional comments
New configurable secondary hotkeys (all keep existing defaults):
C++ (
ZoomIt/ZoomIt/ZoomItSettings.h,Zoomit.cpp,ZoomItSettingsInterop/ZoomItSettings.cpp):DWORDglobals with defaults matching old XOR-derived values; added registry entriesRegisterAllHotkeys, WM_CREATE, and WM_USER_RELOAD_SETTINGS now use stored values directly instead ofbase_mod ^ MOD_SHIFT/MOD_ALTsettings_with_special_semanticswithSPECIAL_SEMANTICS_SHORTCUTC# (
ZoomItProperties.cs,ZoomItViewModel.cs):KeyboardKeysPropertyfields and correspondingDefaultXxxKeystaticsXAML/resources (
ZoomItPage.xaml,Resources.resw):MarkdownTextBlockdescription (showing the derived key as text) with aShortcutControlwithMode=TwoWay.Headerstring resources for the newSettingsCarditemsZoomIt_DemoTypeFAQupdated to reference the reset hotkey as static text (was{0}formatted via converter)Validation Steps Performed
ZoomItSettings.hmatch the previously derived values (backward-compatible registry upgrade)settings_with_special_semanticsmap correctly converts DWORD↔JSON for all 6 new keysShortcutControlelements useMode=TwoWayand bind to ViewModel setters backed byZoomItPropertiesfields