Repository navigation
fix(build): remove GenerateAssemblyInfo=false so assemblies carry version info - #924
Open
Hardik K (hardikkaurani) wants to merge 1 commit into
Open
Hardik K (hardikkaurani) wants to merge 1 commit into
Hardik K (hardikkaurani) wants to merge 1 commit into
Conversation
Author
|
Hi Gavin Barron (@gavinbarron) Vincent Biret (@baywet), submitted this PR to address #852 by removing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #852:
Microsoft.OpenApi.OData.Reader.dllships unversioned (0.0.0.0) since the 2026-01-16 releases.Cause
In commit
0fb398e9(PR #766), legacy MSBuild versioning files (tool/versioning.props, etc.) were removed, but<GenerateAssemblyInfo>false</GenerateAssemblyInfo>remained insrc/Build.props. With assembly-info generation disabled and the legacy toolchain gone, no version attributes (AssemblyVersion,AssemblyFileVersion,AssemblyInformationalVersion) were stamped on the compiled assemblies, leaving them at0.0.0.0.Changes Made
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>and the stale comment fromsrc/Build.props.<Version>already defined inDirectory.Build.props.Fixes #852
cc Gavin Barron (@gavinbarron) Vincent Biret (@baywet)